Page MenuHomePhabricator

Success message is shown when there are errors
Open, Needs TriagePublicBUG REPORT

Description

After clicking the Bulk OCR button, the success message is displayed and then immediately below it a bunch of errors:

bulkocr.png (486×289 px, 36 KB)

Only the error messages should be shown.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1229805 had a related patch set uploaded (by Okerekechinweotito; author: Okerekechinweotito):

[mediawiki/extensions/Wikisource@master] Fix Success message is shown when there are errors. Show appropriate notifications based on success/failure status: * All failed: Errors are shown * Partial success: warning with count * Complete success: original success message

https://gerrit.wikimedia.org/r/1229805

@theprotonade @Samwilson GSOC aspirant here. Please I have a question ...
The current behavior is such that the bulk ocr process will continue even if some pages fail, leading to partial transcriptions ( some pages fail while others succeed )
when OCR for a single page fails , should the entire bulk OCR process abort or should it continue to the next pages ? This detail is important to know as it would better inform on how the success and error tooltips should be handled.
In the meantime , I have made a patch that ;

  • only shows the success tooltip only when OCR is successful on all pages
  • shows a tooltip with type warning for partial success
  • shows a tooltip with type error when all Pages fail

Thanks @Okerekechinweotito!

I think cancelling the whole batch when there's any error is probably safer, and generally more likely to be what people want. If there's an error with one page, it's probably something like the thumbnail not being generated or an API being down, and so retrying with other pages will probably also fail. And if not, then the user can just try again. But if they're just getting a string of red warnings it won't inspire confidence.

The warning and error notifications should be persistent, and stay on the screen for the user's reference.

@Samwilson @theprotonade
Thanks for the clarification
I have made requested updates to my patch

Change #1240467 had a related patch set uploaded (by Ypaula; author: Ypaula):

[mediawiki/extensions/Wikisource@master] Fix success notification shown when bulk OCR pages fail

https://gerrit.wikimedia.org/r/1240467

Wasn't sure if it was too early to start contributing, but I've been following this thread and Wikimedia activities for a while. I'm especially interested in the accessibility impact of this project. I submitted a patch for this bug: Gerrit patch #1240467

I also noticed Okerekechinweotito already has a patch up for this. I read through their approach and found it really helpful for understanding the codebase. I submitted my own patch as a learning exercise.

Any feedback welcome!

After discussion with the org admins and mentors, we’re pleased to share that early contributions are welcome for this project. There’s no need to wait until March 16 to start working on code or submitting your microtask patches; feel free to dive in whenever you’re ready.

@Gopavasanth just announced that early contributions are welcome for this project.
I would like to share that I previously submitted a patch addressing this issue - Gerrit Patch #1229805

Hi everyone
My name Hussein Mmbaga (@Ssein) a fullstack developer and a Swahili Wikipedia administrator from Arusha, Tanzania.
I am interested in working on this task as part of my preparation for GSoC 2026. I have already set up MediaWiki locally on Linux with the Wikisource related extensions and have been exploring the Bulk OCR codebase.I would like to work on it and submit a patch for review.

Thank you!

Change #1252657 had a related patch set uploaded (by Ssein; author: Ssein):

[mediawiki/extensions/Wikisource@master] Fix success message shown when there are errors

https://gerrit.wikimedia.org/r/1252657