Page MenuHomePhabricator

initEditCount counds edits as 1 for users with no actual edits
Closed, ResolvedPublic

Description

I have zero edits on tokwiki:

wikiadmin2023@10.192.23.14(tokwiki)> select count(*) from revision where rev_actor = (select actor_id from actor where actor_name = 'Taavi');
+----------+
| count(*) |
+----------+
|        0 |
+----------+
1 row in set (0.001 sec)

However, the query used by the initEditCount maintenance script thinks I have a single edit:

wikiadmin2023@10.192.23.14(tokwiki)> select user_id, COUNT(actor_user) from user join actor on actor_user = user_id left join revision on rev_actor = actor_id where user_name = 'Taavi' group by user_id;
+---------+-------------------+
| user_id | COUNT(actor_user) |
+---------+-------------------+
|       4 |                 1 |
+---------+-------------------+
1 row in set (0.001 sec)

Event Timeline

Change #1212178 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/core@master] initEditCount: Fix count for users with no edits

https://gerrit.wikimedia.org/r/1212178

Change #1212178 merged by jenkins-bot:

[mediawiki/core@master] initEditCount: Fix count for users with no edits

https://gerrit.wikimedia.org/r/1212178

Change #1213120 had a related patch set uploaded (by Reedy; author: Majavah):

[mediawiki/core@REL1_45] initEditCount: Fix count for users with no edits

https://gerrit.wikimedia.org/r/1213120

Change #1213121 had a related patch set uploaded (by Reedy; author: Majavah):

[mediawiki/core@REL1_44] initEditCount: Fix count for users with no edits

https://gerrit.wikimedia.org/r/1213121

Change #1213122 had a related patch set uploaded (by Reedy; author: Majavah):

[mediawiki/core@REL1_43] initEditCount: Fix count for users with no edits

https://gerrit.wikimedia.org/r/1213122

Change #1213122 merged by jenkins-bot:

[mediawiki/core@REL1_43] initEditCount: Fix count for users with no edits

https://gerrit.wikimedia.org/r/1213122

Change #1213120 merged by jenkins-bot:

[mediawiki/core@REL1_45] initEditCount: Fix count for users with no edits

https://gerrit.wikimedia.org/r/1213120

Change #1213121 merged by jenkins-bot:

[mediawiki/core@REL1_44] initEditCount: Fix count for users with no edits

https://gerrit.wikimedia.org/r/1213121