Page MenuHomePhabricator

Allow following class alias for \MediaWiki\Message\Message in phan-taint-check or add fallback to new proposed namespace
Open, LowPublic

Description

In b90593333c3b0c4221619e2c00edc514af9a22eb the class \MediaWiki\Message\Message was moved from includes/Message/Message.php to includes/language/Message/Message.php as part of T364652.
The new location does not allow the class to autoload via PSR-4 (T353458: Make core classes follow PSR-4)

The class needs to be re-namespaced (T409441: Remove hierarchy, or re-namespace various classes) to \MediaWiki\Language\Message\Message, but that break phan with a class-alias as special handling for Message class is no longer recognized by phan-taint-check.

Event Timeline

This would be similar to r1152415, except we now have fewer references to Message (see codesearch). Basically just the two in MediaWikiSecurityCheckPlugin and then tests.

Change #1309721 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/tools/phan/SecurityCheckPlugin@master] Add special handling for \MediaWiki\Language\Message\Message

https://gerrit.wikimedia.org/r/1309721

Umherirrender triaged this task as Low priority.
Umherirrender updated the task description. (Show Details)

Change #1309721 merged by jenkins-bot:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Add special handling for \MediaWiki\Language\Message\Message

https://gerrit.wikimedia.org/r/1309721

Umherirrender updated the task description. (Show Details)
Umherirrender subscribed.