Page MenuHomePhabricator

ProofreadPages CI breaks without VE integration
Closed, ResolvedPublicBUG REPORT

Description

This empty patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/1212546 is not passing CI.

Current assumption: there is now a conditional load of VE (via https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/1193456), and I'm assuming that ParserFunctions would come as a dependency somewhere of that (probably via Cite), and if it's not loaded, the corresponding parserTests that use this extension are also broken.

MW_ZUUL_RECURSE is true, and EXT_DEPENDENCIES is

mediawiki/extensions/BetaFeatures
mediawiki/extensions/Cite
mediawiki/extensions/ConfirmEdit
mediawiki/extensions/DiscussionTools
mediawiki/extensions/FlaggedRevs
mediawiki/extensions/LabeledSectionTransclusion
mediawiki/extensions/Linter
mediawiki/extensions/Scribunto
mediawiki/extensions/TemplateData
mediawiki/extensions/VisualEditor

Event Timeline

Change #1212601 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Zuul: [mediawiki/extensions/ProofreadPages] add ParserFunctions

https://gerrit.wikimedia.org/r/1212601

Indeed I broke it when I disabled recursion on VisualEditor ( https://gerrit.wikimedia.org/r/c/integration/config/+/1211189 ) which removed a lot of dependencies. Previously the long list included ParserFunctions and was:

AbuseFilter
AntiSpoof
BetaFeatures
CentralAuth
CheckUser
CirrusSearch
Cite
cldr
CodeEditor
CommunityConfiguration
CommunityConfigurationExample
ConfirmEdit
DiscussionTools
Echo
Elastica
EmailAuth
EventBus
EventLogging
EventStreamConfig
FlaggedRevs
Flow
Gadgets
GeoData
GlobalBlocking
GlobalPreferences
GrowthExperiments
GuidedTour
IPInfo
IPReputation
LabeledSectionTransclusion
Linter
LoginNotify
MetricsPlatform
MobileApp
MobileFrontend
OATHAuth
PageImages
PageViewInfo
ParserFunctions
PdfHandler
Popups
Renameuser
Scribunto
SecurePoll
SiteMatrix
TemplateData
TextExtracts
Thanks
TimedMediaHandler
TorBlock
VisualEditor
WebAuthn
WikiEditor
WikimediaEvents
WikimediaMessages

Change #1212601 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/ProofreadPages] add ParserFunctions

https://gerrit.wikimedia.org/r/1212601

hashar claimed this task.

Fixed by adding ParserFunctions as an explicit dependency of ProofreadPage. Thanks for the report!

Change #1218223 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Zuul: [ProofreadPage]: disable recursion

https://gerrit.wikimedia.org/r/1218223

Change #1218223 merged by jenkins-bot:

[integration/config@master] Zuul: [ProofreadPage]: disable recursion

https://gerrit.wikimedia.org/r/1218223