Page MenuHomePhabricator
Create Task
Maniphest T411247

[MEX] M3.1.2 - Improve wbeditentity edit summaries using the “option 5” approach
Closed, ResolvedPublic
Actions

Description

See the parent task (T407877) for the overall goal we want to achieve, and T410130: [MEX] M3.1.2 - Spike - Improve Publish Info Option 5: Use ClaimSummaryBuilder in EditEntity for the implementation approach we want to pursue.

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Nov 28 2025, 11:19 AM
Lucas_Werkmeister_WMDE mentioned this in T410130: [MEX] M3.1.2 - Spike - Improve Publish Info Option 5: Use ClaimSummaryBuilder in EditEntity.
gerritbot added a comment.Nov 28 2025, 11:25 AM

Change #1201726 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Inline classes into EditSummaryHelper

https://gerrit.wikimedia.org/r/1201726

gerritbot added a project: Patch-For-Review.Nov 28 2025, 11:25 AM

Change #1208371 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use EntityDiff for EditSummaryHelper

https://gerrit.wikimedia.org/r/1208371

gerritbot added a comment.Nov 28 2025, 11:25 AM

Change #1208372 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move more summary generation into EditSummaryHelper

https://gerrit.wikimedia.org/r/1208372

Lucas_Werkmeister_WMDE claimed this task.Nov 28 2025, 11:25 AM
Lucas_Werkmeister_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Nov 28 2025, 11:25 AM

Change #1208373 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Refactor EditSummaryHelper for different modules

https://gerrit.wikimedia.org/r/1208373

gerritbot added a comment.Nov 28 2025, 11:25 AM

Change #1208374 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use ClaimSummaryBuilder in EditSummaryHelper

https://gerrit.wikimedia.org/r/1208374

gerritbot added a comment.Nov 28 2025, 11:25 AM

Change #1208375 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Hard-code module name in ClaimSummaryBuilder

https://gerrit.wikimedia.org/r/1208375

gerritbot added a comment.Nov 28 2025, 11:25 AM

Change #1210645 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Further improve wbeditentity summaries for terms

https://gerrit.wikimedia.org/r/1210645

gerritbot added a comment.Dec 1 2025, 5:01 PM

Change #1213532 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Detect additional statement changes in EditSummaryHelper

https://gerrit.wikimedia.org/r/1213532

gerritbot added a comment.Dec 1 2025, 5:01 PM

Change #1213533 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add edit summaries for editing multiple statements

https://gerrit.wikimedia.org/r/1213533

gerritbot added a comment.Dec 2 2025, 2:44 PM

Change #1214066 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Refactor EditSummaryHelperTest for expected summaries

https://gerrit.wikimedia.org/r/1214066

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Dec 2 2025, 2:45 PM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

Moving this into Ready for Peer Review – one or two changes at the very end of the chain still need a bit of work from me (anything that says “TODO” or “WIP”), but the rest should be okay to review and merge already and we should really start to get this chain of changes shorter instead of longer ^^

gerritbot added a comment.Dec 2 2025, 6:00 PM

Change #1201726 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Inline classes into EditSummaryHelper

https://gerrit.wikimedia.org/r/1201726

gerritbot added a comment.Dec 2 2025, 6:00 PM

Change #1208371 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use EntityDiff for EditSummaryHelper

https://gerrit.wikimedia.org/r/1208371

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 2 2025, 7:00 PM
gerritbot added a comment.Dec 3 2025, 9:31 AM

Change #1208372 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move more summary generation into EditSummaryHelper

https://gerrit.wikimedia.org/r/1208372

gerritbot added a comment.Dec 3 2025, 12:22 PM

Change #1208373 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Refactor EditSummaryHelper for different modules

https://gerrit.wikimedia.org/r/1208373

gerritbot added a comment.Dec 3 2025, 12:22 PM

Change #1214066 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Refactor EditSummaryHelperTest for expected summaries

https://gerrit.wikimedia.org/r/1214066

gerritbot added a comment.Dec 9 2025, 12:30 PM

Change #1208374 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use ClaimSummaryBuilder in EditSummaryHelper

https://gerrit.wikimedia.org/r/1208374

Lucas_Werkmeister_WMDE added subscribers: Alice.moutinho, Arian_Bozorg, Lydia_Pintscher.Dec 10 2025, 11:41 AM

@Arian_Bozorg, or perhaps @Lydia_Pintscher or @Alice.moutinho: What should the new edit summaries look like?

In the attached Gerrit change, I added summaries that would look like this:

Changed 2 statements: instance of (P31)

Changed statements for 2 properties

The former is used if two or more statements are changed, but they all use the same property (this would be the case in MEX); the latter is used if the statements use different properties.

Lucas_Werkmeister_WMDE added a comment.EditedDec 11 2025, 2:40 PM

Hm, probably we should have special cases of those two summaries for when statements were only added or only removed?

Added 587 statements: signatory (P1891)

(example seen on Constitution of Brazil, though those statements were actually added in rather more than a single edit)

ArthurTaylor claimed this task.Mon, Dec 15, 10:27 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
Lucas_Werkmeister_WMDE added a comment.Tue, Dec 16, 11:51 AM

From a meeting with Arian: the comments shown above are okay; we should also include “Added” and “Removed” versions of them.

gerritbot added a comment.Wed, Dec 17, 8:39 AM

Change #1213532 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Detect additional statement changes in EditSummaryHelper

https://gerrit.wikimedia.org/r/1213532

gerritbot added a comment.Wed, Dec 17, 9:37 AM

Change #1219124 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Refactor getEditSummaryForClaims to avoid instanceof

https://gerrit.wikimedia.org/r/1219124

gerritbot added a comment.Wed, Dec 17, 9:37 AM

Change #1219125 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Refactor getEditSummaryForLanguage to avoid instanceof

https://gerrit.wikimedia.org/r/1219125

gerritbot added a comment.Wed, Dec 17, 10:18 AM

Change #1213533 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add edit summaries for editing multiple statements

https://gerrit.wikimedia.org/r/1213533

gerritbot added a comment.Wed, Dec 17, 10:18 AM

Change #1208375 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Hard-code module name in ClaimSummaryBuilder

https://gerrit.wikimedia.org/r/1208375

gerritbot added a comment.Wed, Dec 17, 11:08 AM

Change #1210645 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Further improve wbeditentity summaries for terms

https://gerrit.wikimedia.org/r/1210645

ArthurTaylor reassigned this task from ArthurTaylor to Lucas_Werkmeister_WMDE.Wed, Dec 17, 11:24 AM
ArthurTaylor subscribed.
gerritbot added a comment.Fri, Dec 19, 11:39 AM

Change #1219849 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] EditSummaryHelper: Extract getFallbackEditSummary()

https://gerrit.wikimedia.org/r/1219849

gerritbot added a comment.Fri, Dec 19, 11:54 AM

Change #1219851 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] EditSummaryHelper: Split getEditSummaryForLanguage()

https://gerrit.wikimedia.org/r/1219851

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Fri, Dec 19, 2:47 PM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.

I think this can go into product review, despite the open follow-ups to improve the code a bit more.

gerritbot added a comment.Fri, Dec 19, 2:52 PM

Change #1219849 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] EditSummaryHelper: Extract getFallbackEditSummary()

https://gerrit.wikimedia.org/r/1219849

Arian_Bozorg closed this task as Resolved.Wed, Jan 7, 2:27 PM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

Looks good to me! Thank you :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits