Page MenuHomePhabricator

rest gateway: Record x-trusted-request and x-provenance headers in access logs
Closed, ResolvedPublic

Description

It would be useful to record the headers described in https://wikitech.wikimedia.org/wiki/CDN/Backend_api in the access logs of the rest gateway (and the api gateway). They provide information that is extremely useful for investigating incidents and identifying high volume unauthenticated clients.

Question: are there any restrictions about recording this information in logs for some time (e.g. 90 days)? The same log would also include the client's IP address. It may also contain the user name or user ID of authenticated users in certain cases.

Event Timeline

Question: are there any restrictions about recording this information in logs for some time (e.g. 90 days)? The same log would also include the client's IP address. It may also contain the user name or user ID of authenticated users in certain cases.

For 90 days this seems totally fine -- the same data all exists in webrequest, and that's how long it is retained there.