Special:UserRights: After invalid "Other" expiry the input disappears
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Nov 28 2025, 1:09 PM

Description

What is the problem?

When adding a user to a group, if I select "Other" expiry option and enter an invalid value in the input box, after I submit the form I see a validation error but the input box does not appear.

You have to select a different expiry option and then select "Other" again for it to reappear.

Steps to reproduce problem

Login as a user in the stewards group
Go to Special:UserRights/<user> for any existing <user>
Check one of the checkboxes, open the expiry dropdown and select "Other"
A new input box should appear. Enter an invalid value, e.g. 1.5 hours
Submit

Environment

Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.46.0-alpha (8d01c6d) 22:48, 27 November 2025.

Screenshots

invalid_other_expiry_before.png (516×672 px, 60 KB)

invalid_other_expiry_after.png (543×657 px, 63 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	SelectWithInputWidget: Avoid FOUC when initial value is not "other"	mediawiki/core	master	+13 -9

Customize query in gerrit

Related Objects

Mentioned In: T409714: Update UserGroupAssignmentService to check restricted groups
Mentioned Here: rMW8d01c6d95933: tests: Validate namespaced classes against folder structure for PSR-4

Event Timeline

dom_walden created this task.Nov 28 2025, 1:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2025, 1:09 PM

dom_walden mentioned this in T409714: Update UserGroupAssignmentService to check restricted groups.Nov 28 2025, 1:38 PM

Uses the selectorother html form field backed with OOUI, so maybe something with SelectWithInputWidget and the inital state.

Umherirrender unsubscribed.Nov 29 2025, 11:47 AM

Change #1215151 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] SelectWithInputWidget: Avoid FOUC when initial value is not "other"

https://gerrit.wikimedia.org/r/1215151

gerritbot added a project: Patch-For-Review.Dec 4 2025, 1:02 PM

It's actually a bug specific to Special:UserRights, so adding back the tags, but I'm fixing it by improving SelectWithInputWidget so that the code that caused the bug is no longer needed.

Tchanders edited projects, added Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12); removed Product Safety and Integrity.Dec 5 2025, 3:59 PM

Tchanders moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.

Change #1215151 merged by jenkins-bot:

[mediawiki/core@master] SelectWithInputWidget: Avoid FOUC when initial value is not "other"

https://gerrit.wikimedia.org/r/1215151

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 5 2025, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2025, 5:30 PM

Tchanders moved this task from Needs review to Done on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.Dec 9 2025, 12:59 PM

mszwarc closed this task as Resolved.Dec 15 2025, 11:03 AM

	F70711289: invalid_other_expiry_after.png
	Nov 28 2025, 1:09 PM

	F70711281: invalid_other_expiry_before.png
	Nov 28 2025, 1:09 PM

Special:UserRights: After invalid "Other" expiry the input disappearsClosed, ResolvedPublicBUG REPORTActions