Page MenuHomePhabricator

Handle 5xx and show service unavailable page
Open, Needs TriagePublic

Description

This task has two parts:

  1. Make sure all errors are handled and throw a 4xx error. If during any flow we see an exception, which is not handled, it throws 5xx (this should not be the case).
  2. Since 5xx error usually mean service is unavailable (this should ideally happen when server is unavailable/unhealthy). In this case we should make a static Service Unavailable page, and show it (via React).

The page should look like this

image.png (1×1 px, 250 KB)

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Fix error handling: distinguish 4xx client from 5xx server errors, add Service Unavailable pagecloudvps-repos/videocuttool/VideoCutTool!56sanjaisiddharthanmastermaster
Customize query in GitLab

Related Objects

Event Timeline

Artwork for service unavailable page

image.png (2×3 px, 1 MB)

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

sanjaisiddharthan opened https://gitlab.wikimedia.org/cloudvps-repos/videocuttool/VideoCutTool/-/merge_requests/56

Fix error handling: distinguish 4xx client from 5xx server errors, add Service Unavailable page

Hi @Reputation22 ,
I have submitted a patch a week ago. Can you check whether things are good ?

Hi @Reputation22 ,
I have submitted a patch a week ago. Can you check whether things are good ?

uhmm sure..let me have a look

hi @sanjaisid left some comments in the MR
please address them and revert back on them

thanks

HI @Reputation22 ,
I have addressed those. Please check when you find time

Hello! I would like to work on this task as my first contribution. Is it still available?