| Nirmos | |
| Nov 30 2025, 9:18 AM |
| F70784070: patrollink clear both.png | |
| Nov 30 2025, 9:18 AM |
| F70784066: patrollink current.png | |
| Nov 30 2025, 9:18 AM |
I'm not a CSS expert, but .patrollink should probably have clear: both or something similar to ensure that the patrol link is below all content from .mw-parser-output.
The file that needs to be changed is https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.action.styles/styles.less
Before:
After:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add clear: both to .patrollink to fix patrolling link position | mediawiki/core | master | +1 -0 |
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Change #1213085 had a related patch set uploaded (by Kavaljeet Singh; author: Kavaljeet Singh):
[mediawiki/core@master] T411322: Add clear: both to .patrollink to fix patrolling link position
Change #1213085 had a related patch set uploaded (by Pppery; author: Kavaljeet Singh):
[mediawiki/core@master] Add clear: both to .patrollink to fix patrolling link position
@jsn.sherman Do you have any objections to the proposed patch, or can we move forward with this?