Page MenuHomePhabricator

CI fails in REL1_43 due to CI infrastructure change to not recursively expand dependencies
Closed, ResolvedPublic

Description

After DiscussionTools had CI dependencies recursion disabled (T389998), Tests failed for the REL1_43 branch and patches would need to be backported.

The recursion has been re-enabled until this is fixed.

DiscussionTools DONE

19:36:41 1) MediaWiki\Extension\DiscussionTools\Tests\ApiParseDiscussionToolsTest::testApiParseSections
19:36:41 Undefined array key "extensionData"
19:36:41 
19:36:41 /workspace/src/extensions/DiscussionTools/tests/phpunit/integration/ApiParseDiscussionToolsTest.php:35
19:36:41 /workspace/src/tests/phpunit/includes/api/ApiTestCase.php:338

Solved by backporting to REL1_43 and REL1_44 https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/1193794

Cite

See patches attached to T406323: Make it possible to run Cite tests without VisualEditor or WikiEditor which would require backports.

19:36:41 1) ResourcesTest::testValidDependencies
19:36:41 Dependencies that do not exist
19:36:41 Failed asserting that two arrays are equal.
19:36:41 --- Expected
19:36:41 +++ Actual
19:36:41 @@ @@
19:36:41  Array (
19:36:41      'ext.cite.wikiEditor' => Array (
19:36:41 +        0 => 'ext.wikiEditor'
19:36:41      )
19:36:41  )
19:36:41 
19:36:41 /workspace/src/tests/phpunit/structure/ResourcesTest.php:81
Logs generated by test
19:36:41 
19:36:41 2) ResourcesTest::testMissingMessages
19:36:41 Message 'thanks-button-thank' required by 'ext.discussionTools.init' must exist
19:36:41 Failed asserting that false is true.
19:36:41 
19:36:41 /workspace/src/tests/phpunit/structure/ResourcesTest.php:121

E.g.
https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php81/20230/console

Also:

16:07:42 FAILED TESTS:
16:07:42   ve.ce.Surface (MW)
16:07:42     ✖ beforePaste/afterPaste
16:07:42       Firefox 140.0 (Linux x86_64)
16:07:42     VE references not stripped: HTML
16:07:42     Expected: "<p>a<sup typeof=\"mw:Extension/ref\" data-mw=\"{&quot;name&quot;:&quot;ref&quot;}\" class=\"mw-ref reference\"><a><span class=\"mw-reflink-text\"><span class=\"cite-bracket\">[</span>1<span class=\"cite-bracket\">]</span></span></a></sup>b</p>"
16:07:42     Actual: "<p>a<span typeof=\"mw:Extension/undefined\" data-mw=\"{}\"></span>b</p>"
16:07:42     ve.test.utils.runSurfacePasteTest/<@http://localhost:9876/load.php?modules=color-picker%2CdiffMatchPatch%2Cdompurify%2Cmoment%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpapaparse%2Crangefix%2Csinonjs%2Cspark-md5%2CtreeDiffer%2Cunicodejs%7Cext.visualEditor.data%2Cicons-licenses%2CmoduleIcons%2CmoduleIndicators%7Cjquery.client%2ChighlightText%2ClengthLimit%2CmakeCollapsible%2Cspinner%2Ctablesorter%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cjquery.spinner.styles%7Cjquery.tablesorter.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CForeignUpload%2CString%2CTitle%2CUpload%2CUri%2Capi%2Ccldr%2Ccookie%2Cdeflate%2Cdiff%2Cexperiments%2Cinspect%2CjqueryMsg%2Clanguage%2CmessagePoster%2Cnotification%2Cpulsatingdot%2Cqunit-testrunner%2Crouter%2Cstorage%2CtempUserCreated%2Ctemplate%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.ForeignStructuredUpload.BookletLayout%7Cmediawiki.Upload.BookletLayout%7Cmediawiki.action.view.postEdit%2CredirectPage%7Cmediawiki.diff.styles%7Cmediawiki.editfont.styles%7Cmediawiki.interface.helpers.styles%7Cmediawiki.language.months%2Cnames%2Ctestdata%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.gallery.styles%7Cmediawiki.page.ready%7Cmediawiki.rcfilters.filters.ui%7Cmediawiki.skinning.content.parsoid%7Cmediawiki.template.mustache%7Cmediawiki.widgets.AbandonEditDialog%2CCategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CTable%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-accessibility%2Cicons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-list%2Cicons-editing-styling%2Cicons-interactions%2Cicons-layout%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cicons-user%2Cindicators%7Cskins.vector.clientPreferences%7Csocket.io%7Ctest.MediaWiki%2CVector%2CVisualEditor&version=82sda:3381:509
16:07:42     fire@http://localhost:9876/load.php?modules=jquery%7Cmediawiki.base&version=uja8i:42:76
16:07:42     fireWith@http://localhost:9876/load.php?modules=jquery%7Cmediawiki.base&version=uja8i:43:264
16:07:42     mightThrow@http://localhost:9876/load.php?modules=jquery%7Cmediawiki.base&version=uja8i:45:586
16:07:42     Deferred/then/resolve/</process<@http://localhost:9876/load.php?modules=jquery%7Cmediawiki.base&version=uja8i:45:643

Event Timeline

Hslater updated the task description. (Show Details)
Jdforrester-WMF renamed this task from CI fails to CI fails in REL1_43 due to CI infrastructure change to not recursively expand dependencies.Dec 1 2025, 1:08 PM

Change #1213465 had a related patch set uploaded (by Krinkle; author: Hashar):

[mediawiki/extensions/DiscussionTools@REL1_43] tests: skip tests when MobileFrontend is not loaded

https://gerrit.wikimedia.org/r/1213465

Change #1213466 had a related patch set uploaded (by Krinkle; author: Hashar):

[mediawiki/extensions/DiscussionTools@REL1_43] tests: fix extensionData without MobileFrontend

https://gerrit.wikimedia.org/r/1213466

These backports address PHPUnit. The QUnit one probably needs these two:

I suppose we'd want to also add the Cite-part of these, but I don't know the state of that code in REL1_43, and whether that's feasible/desirable. I'll leave that to @Esanders and @DLynch.

@hashar: Did you plan to back-port your fixes for release branches?

I have often backported patches to release branches, but it looks like I have missed a few of them :-\

Change #1213471 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Zuul: make DiscussionTools to use recursion again

https://gerrit.wikimedia.org/r/1213471

Change #1213473 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/DiscussionTools@REL1_39] (DO NOT SUBMIT) verify REL1_39 CI

https://gerrit.wikimedia.org/r/1213473

Change #1213475 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/DiscussionTools@REL1_44] tests: fix extensionData without MobileFrontend

https://gerrit.wikimedia.org/r/1213475

Change #1213476 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/DiscussionTools@REL1_44] tests: skip tests when MobileFrontend is not loaded

https://gerrit.wikimedia.org/r/1213476

Change #1213486 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/Thanks@REL1_39] Only load mobilediff when MobileFrontend is available

https://gerrit.wikimedia.org/r/1213486

Change #1213471 merged by jenkins-bot:

[integration/config@master] Zuul: make DiscussionTools to use recursion again

https://gerrit.wikimedia.org/r/1213471

Change #1213466 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_43] tests: fix extensionData without MobileFrontend

https://gerrit.wikimedia.org/r/1213466

Change #1213465 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_43] tests: skip tests when MobileFrontend is not loaded

https://gerrit.wikimedia.org/r/1213465

Change #1213475 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_44] tests: fix extensionData without MobileFrontend

https://gerrit.wikimedia.org/r/1213475

Change #1213476 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@REL1_44] tests: skip tests when MobileFrontend is not loaded

https://gerrit.wikimedia.org/r/1213476

See also T412403 for other similar failures in other repos (at least Translate, EventLogging).

Change #1217602 had a related patch set uploaded (by Daimona Eaytoy; author: Esanders):

[mediawiki/extensions/VisualEditor@REL1_43] Rename ve.ce.Surface.test -> ve.ce.ClipboardHandler.test

https://gerrit.wikimedia.org/r/1217602

Change #1217602 abandoned by Daimona Eaytoy:

[mediawiki/extensions/VisualEditor@REL1_43] Rename ve.ce.Surface.test -> ve.ce.ClipboardHandler.test

Reason:

On closer inspection, this needs I9066350f73eed7f2f2b29c8f22df43e06e990955 and I'm not going to take responsibility of backporting that change in a million years.

https://gerrit.wikimedia.org/r/1217602

These backports address PHPUnit. The QUnit one probably needs these two:

I suppose we'd want to also add the Cite-part of these, but I don't know the state of that code in REL1_43, and whether that's feasible/desirable. I'll leave that to @Esanders and @DLynch.

I tried backporting those two, but quickly realized that the ClipboardHandler itself was introduced in r1079286 (REL1_44). I'm not going to backport a 3k-line change in a repository I'm not familiar with. But, this is currently breaking CI for other extensions (e.g. Translate and things that depend on it) in 1.39 and 1.43, so it would be nice to fix, at least for 1.43 (1.39 will be EOL in a few weeks).

Umherirrender subscribed.

These backports address PHPUnit. The QUnit one probably needs these two:

I suppose we'd want to also add the Cite-part of these, but I don't know the state of that code in REL1_43, and whether that's feasible/desirable. I'll leave that to @Esanders and @DLynch.

I tried backporting those two, but quickly realized that the ClipboardHandler itself was introduced in r1079286 (REL1_44). I'm not going to backport a 3k-line change in a repository I'm not familiar with. But, this is currently breaking CI for other extensions (e.g. Translate and things that depend on it) in 1.39 and 1.43, so it would be nice to fix, at least for 1.43 (1.39 will be EOL in a few weeks).

Backported https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1130118 via https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/1220017 and moved the new content to the old file.

Change #1213473 abandoned by Reedy:

[mediawiki/extensions/DiscussionTools@REL1_39] (DO NOT SUBMIT) verify REL1_39 CI

Reason:

REL1_39 is EOL - T403199

https://gerrit.wikimedia.org/r/1213473

Change #1213486 abandoned by Reedy:

[mediawiki/extensions/Thanks@REL1_39] Only load mobilediff when MobileFrontend is available

Reason:

REL1_39 is EOL - T403199

https://gerrit.wikimedia.org/r/1213486