Experimental DisambiguationEditCheck doesn't work in suggestion mode
Open, Needs TriagePublic
Actions

Assigned To

Authored By

	Esanders
	Dec 1 2025, 4:55 PM

Description

This is because checking if a link is a disambig is asynchronous, and when I wrote the check that wasn't supported.

Since we word on ToneCheck we can now have checks that return promises.

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	DisambiguationEditCheck: Fix to work with uncached links	mediawiki/extensions/VisualEditor	master	+17 -13

Status	Assigned	Task
Open	None	T360489 [EPIC] Generate and present edit suggestions at scale
Open	None	T404600 [MILESTONE] Run controlled experiment of Suggestion Mode MVP
Open	None	T399611 [MILESTONE] Deploy Suggestion Mode MVP as a beta feature
Open	Esanders	T411380 Experimental DisambiguationEditCheck doesn't work in suggestion mode

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2025, 4:55 PM

Change #1213531 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] DisambiguationEditCheck: Fix to work with uncached links

Change #1213531 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] DisambiguationEditCheck: Fix to work with uncached links