This is because checking if a link is a disambig is asynchronous, and when I wrote the check that wasn't supported.
Since we word on ToneCheck we can now have checks that return promises.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| DisambiguationEditCheck: Fix to work with uncached links | Esanders | mediawiki/extensions/VisualEditor | master | +17 -13 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T360489 [EPIC] Offer edit suggestions as a service | |||
| Open | None | T414853 [MILESTONE] Deploy Suggestion Mode as a default-on feature. | |||
| Open | Quiddity | T430878 Publish Suggestion Mode controlled experiment findings on-wiki | |||
| Resolved | ppelberg | T404600 [MILESTONE] Run controlled experiment of Suggestion Mode MVP | |||
| Resolved | ppelberg | T415320 [MILESTONE] Deploy Suggestion Mode MVP as a beta feature (all Wikipedias) | |||
| Resolved | ppelberg | T399611 [MILESTONE] Deploy Suggestion Mode MVP as a beta feature (en.wiki) | |||
| Resolved | Esanders | T411380 Experimental DisambiguationEditCheck doesn't work in suggestion mode |
Event Timeline
Comment Actions
Change #1213531 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/VisualEditor@master] DisambiguationEditCheck: Fix to work with uncached links
Comment Actions
Change #1213531 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DisambiguationEditCheck: Fix to work with uncached links