Page MenuHomePhabricator

CentralNotice Banner Status Codes are broken in Turnilo
Closed, ResolvedPublic

Description

When we serve banner impressions through centralnotice, those impressions produce a variety of status codes that are normally visible in Turnilo. Here's a list of definition of those status codes.

In a normal banner test, we produce a range of status codes, particularly code 6 = banner shown and code 2 = banner canceled.

We are not getting any of those codes from the last few weeks, with 99% of banner impressions labeled as status code 6 = banner_shown, even though that can't be the case.

Here's a sample turnilo query with the issue, displaying status codes just for the last mobile large banner pre-test we ran in November.

Event Timeline

When banners are not shown for the highest priority campaign, but other campaigns are active, the selection logic continues down the list of active campaigns. If it eventually chooses a banner from one of the other campaigns, that banner is logged in the impression data in turnilo with its status code. If it gets to the end of the campaign list and the chosen banner is still hidden, only that final banner will show in the turnilo data with a non-'shown' status code.

Fundraising campaigns are run at the highest priority, so the selected banner for that campaign will only show up in the Turnilo data with a 'hidden' status code if there are no lower-priority campaigns available to use that page view.

Ever since The Wikipedia Asia Month 2025 Global campaign went live (CN admin says start date 11/1 but impressions begin to appear 11/8), there has been a lower-priority campaign available targeting all of the readers targeted by the WMF_FR campaigns. So while that's still up, any WMF_FR banner that ends up hidden is not logged to Turnilo with a 2.x status

Looking at a graph of status codes in general, with no banner or campaign filter, we can see that there are still plenty of 2.x ones being logged: https://w.wiki/GTHt

@AKanji-WMF ^^^ is an example of the fallthrough that would be disrupted by serving the donor badge as a CN banner. Note that a logged out user on en.wikipedia.org who closes the fundraising banner will see a banner from Wikipedia Asian Month on their next pageview. If they hide THAT banner, they will see one from Wiki Science Competition 2025 on the following pageview.

Thanks @Ejegg - just to note I have seen this and will discuss with @spatton

Ejegg claimed this task.