Page MenuHomePhabricator

Deploy extension:WP25EasterEggs to beta cluster
Closed, ResolvedPublic

Description

This task covers the work needed to deploy extension:WP25EasterEggs to the beta cluster, following process outlined here.

Target date (for beta cluster launch): January 5th 2026

Process

  1. Add the new extension submodule to the git mediawiki/extensions repo if it's not already in it. See example. This will result in the code being deployed (unused) to the Beta Cluster. https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/+/refs/heads/master/WP25EasterEggs
  2. Move your extension's CI config to the "Wikimedia production" section, add the "in-wikimedia-production" job template, and make sure it has and passes all the expected jobs for production code: https://gerrit.wikimedia.org/r/c/integration/config/+/1213565
  3. Add your extension to the json make-wmf-branch release tool at least two weeks prior to your target date for enabling on the Beta Cluster. It will add the extension as a submodule of mediawiki/core when the weekly deploy branch is cut, and the code will be deployed (unused) to production (see explanation in the next step). https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/221

Acceptance criteria

  • extension:WP25EasterEggs is live branched so that it can be enabled on beta cluster

Event Timeline

Change #1213565 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[integration/config@master] Adding extension:WP2EasterEggs to "in-wikimedia-production" job template

https://gerrit.wikimedia.org/r/1213565

@bd808 yes, we do plan on getting a security review, per that task you mention above, as well as doing a first pass ourselves in T411130, but given the holiday train schedule, as well as the tight timeline for getting this to production in Feb. I'm just hoping to get the ball rolling on the release-prep process in order to make these tight timelines. 🤞

Change #1213565 merged by jenkins-bot:

[integration/config@master] Adding extension:WP2EasterEggs to "in-wikimedia-production" job template

https://gerrit.wikimedia.org/r/1213565

Change #1213994 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/WP25EasterEggs@master] Jenkins job validation (DO NOT SUBMIT)

https://gerrit.wikimedia.org/r/1213994

Change #1213994 abandoned by Hashar:

[mediawiki/extensions/WP25EasterEggs@master] Jenkins job validation (DO NOT SUBMIT)

https://gerrit.wikimedia.org/r/1213994

I have deployed the CI configuration which enabled phan static analysis for the repository. I have send an empty change and surely it failed to pass Phan:

src/CommunityConfigurationSchema.php:7 PhanUndeclaredExtendedClass Class extends undeclared class \MediaWiki\Extension\CommunityConfiguration\Schema\JsonSchema
src/CommunityConfigurationSchema.php:9 PhanUndeclaredConstantOfClass Reference to undeclared class constant \MediaWiki\Extension\WP25EasterEggs\CommunityConfigurationSchema::TYPE
src/CommunityConfigurationSchema.php:9 PhanUndeclaredConstantOfClass Reference to undeclared class constant \MediaWiki\Extension\WP25EasterEggs\CommunityConfigurationSchema::TYPE_STRING
src/CommunityConfigurationSchema.php:10 PhanUndeclaredConstantOfClass Reference to undeclared class constant \MediaWiki\Extension\WP25EasterEggs\CommunityConfigurationSchema::ENUM
src/CommunityConfigurationSchema.php:11 PhanUndeclaredConstantOfClass Reference to undeclared class constant \MediaWiki\Extension\WP25EasterEggs\CommunityConfigurationSchema::DEFAULT
src/Hooks.php:58 PhanTypeMismatchReturn Returning ['key'=>$key,'value'=>$value,'isEnabled'=>$isEnabled] of type array{key:'wp25eastereggs-enable',value:mixed|null,isEnabled:'0'|'1'} but getUserPrefEnabled() is declared to return array{key:string,value:mixed,isEnabled:bool}
src/Hooks.php:85 PhanTypeSuspiciousStringExpression Suspicious type bool of a variable or expression $userPrefEnabled['isEnabled'] used to build a string. (Expected type to be able to cast to a string)

Change #1214001 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Zuul: [mediawiki/extensions/WP25EasterEggs] Add CommunityConfiguration phan dependency

https://gerrit.wikimedia.org/r/1214001

Change #1214001 merged by jenkins-bot:

[integration/config@master] Zuul: [WP25EasterEggs] Add CommunityConfiguration phan dependency

https://gerrit.wikimedia.org/r/1214001

Change #1214005 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/WP25EasterEggs@master] phan: add CommunityConfiguration

https://gerrit.wikimedia.org/r/1214005

Change #1217467 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Zuul: [WP25EasterEggs] enable recursion

https://gerrit.wikimedia.org/r/1217467

Change #1217467 merged by jenkins-bot:

[integration/config@master] Zuul: [WP25EasterEggs] enable recursion

https://gerrit.wikimedia.org/r/1217467

Change #1214005 merged by jenkins-bot:

[mediawiki/extensions/WP25EasterEggs@master] phan: add CommunityConfiguration

https://gerrit.wikimedia.org/r/1214005

Jdrewniak claimed this task.

Thank you for all your help on this @hashar! I think this task can be closed out now that the extension has been branched. I've created a follow-up task for enabling the extension here: T415372.