Page MenuHomePhabricator

Gravy google-pay - Prefix in first name
Closed, ResolvedPublic

Description

I'm seeing a noticeable number of donors not being merged with existing contacts as they have a prefix in their first name - e.g

'first_name' => 'Miss'
'last_name' => 'Eliza Doolittle'

I'm not sure how we are collecting the data to wind up like this....

Event Timeline

We should fix on ingress but I'm also looking at handling the merges in deduper

Change #1213630 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] WIP - handle mis-placed prefix

https://gerrit.wikimedia.org/r/1213630

Change #1214162 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Avoid adding bad name parts to Gravy messages

https://gerrit.wikimedia.org/r/1214162

Change #1214162 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Avoid adding bad name parts to Gravy messages

https://gerrit.wikimedia.org/r/1214162

We deployed the fix for the front-end to stop sending first_name and last_name to the donations queue from gravy forms if we've just split those out from a full_name.

XenoRyet set Final Story Points to 4.