Given that an edit is not on a target wiki of event
When submitting that edit via the API
Then return an error: "Add an edit on a target wiki of the event."
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Check revision is on one of the targeted wikis for the specified event | Mhorsey | mediawiki/extensions/CampaignEvents | master | +94 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T400951 Post-MVP: Collaborative Contributions | |||
| Resolved | MHorsey-WMF | T403727 Allow organizer or editor to add an edit | |||
| Open | None | T408256 [Epic] Collaborative contributions fix it tasks | |||
| Resolved | MHorsey-WMF | T411477 Validate that an edit belongs to a target wiki |
Event Timeline
Comment Actions
Change #1214033 had a related patch set uploaded (by Mhorsey; author: Mhorsey):
[mediawiki/extensions/CampaignEvents@master] Check revision is on one of the targeted wikis for the specified event
Comment Actions
Test wiki created on Patch demo by MHorsey-WMF using patch(es) linked to this task:
https://ad14911813.catalyst.wmcloud.org/w/
Comment Actions
Change #1214033 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Check revision is on one of the targeted wikis for the specified event
Comment Actions
Given that an edit is not on a target wiki of event
When submitting that edit via the API
✅ Then return an error: "Add an edit on a target wiki of the event."
{
"errorKey": "campaignevents-event-contribution-not-target-wiki",
"messageTranslations": {
"en": "Add an edit on a target wiki of the event."
},
"httpCode": 400,
"httpReason": "Bad Request"
}
working as expected, nice work, sending to product sign off
Comment Actions
Test wiki on Patch demo by MHorsey-WMF using patch(es) linked to this task was deleted: