Page MenuHomePhabricator

Improve code quality for confirm email builder classes
Closed, ResolvedPublic2 Estimated Story Points

Description

In T396155: [Epic] Improve verification email (WE1.1.22 FY2025-26), @Urbanecm_WMF wrote new classes for confirm email building. There are further opportunities for improving the code quality of the classes created here, which are tracked within this task.

Acceptance criteria

  • Add interface documentation for IConfirmEmailBuilder, ConfirmEmailData and ConfirmEmailContent that describes what it is for and how it should be used
  • Consider further generalizing ConfirmEmailConfirm and/or ConfirmEmailSender::sendEmailToRecipient to all emails (as the emailing logic is not specific to confirm email) and fill out appropriate Phabricator tasks (filled as T410807: Improve other verification related emails: add email, change email, remove email)

Event Timeline

Urbanecm_WMF moved this task from Inbox to Estimated tasks backlog on the Growth-Team board.
Urbanecm_WMF set the point value for this task to 2.

Change #1220353 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] docs(ConfirmEmail): Add missing interface/method docstrings

https://gerrit.wikimedia.org/r/1220353

Change #1220353 merged by jenkins-bot:

[mediawiki/core@master] docs(ConfirmEmail): Add missing interface/method docstrings

https://gerrit.wikimedia.org/r/1220353