Page MenuHomePhabricator

Collapsed table of contents button shows in edit mode and is non-functional
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Collapse the read-mode table of contents sidebar (so it becomes the button by the heading / the floating button)
  • Edit the page in VisualEditor

What happens?:

The TOC button appears, but opens an empty popup.

CleanShot 2025-12-02 at 12.32.29@2x.png (848×1 px, 197 KB)

CleanShot 2025-12-02 at 12.32.52@2x.png (420×924 px, 44 KB)

What should have happened instead?:

Probably the button should also be hidden, until T380598 is worked on to give in-VE editing a live-updating TOC.

This is presumably a symptom of T379444 not having been worked on yet to provide a proper menu-disabling API, and so the current menu-hiding hack used by VE (T379443) is successfully hiding the menu but doesn't know about the (new?) button.

Event Timeline

DLynch renamed this task from Collapsed table ofcontents button shows in edit mode and is non-functional to Collapsed table of contents button shows in edit mode and is non-functional.Tue, Dec 2, 6:36 PM

They're related, for sure, but I wouldn't call it a duplicate.

Change #1214671 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Hide Vector's titlebar TOC when the sidebar is collapsed

https://gerrit.wikimedia.org/r/1214671

Change #1214671 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Hide Vector's titlebar TOC when the sidebar is collapsed

https://gerrit.wikimedia.org/r/1214671

LMora-WMF subscribed.

@Etonkovidova to QA, and let us know if you need anything further from REx