Page MenuHomePhabricator
Create Task
Maniphest T411578

hCaptcha edit attempt logs: Normalize line endings
Open, Needs TriagePublic
Actions

Description

Summary

Some diffs are not generated correctly due to mismatched line endings that vary across systems ("\r\n" compared to '\n"). We should use TextContent::normalizeLineEndings() in calculating the proposed content diff.

Acceptance criteria

  • Edits that use different line endings in the text editor do not result in malformed diffs in the mediawiki.hcaptcha.edits event logging data

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
hCaptchaEditAttempt logging: Normalize line endingsmediawiki/extensions/WikimediaEventsmaster+32 -5
hCaptchaEditAttempt logging: Normalize line endingsmediawiki/extensions/WikimediaEventswmf/1.46.0-wmf.5+32 -5
hCaptchaEditAttempt logging: Normalize line endingsmediawiki/extensions/WikimediaEventswmf/1.46.0-wmf.4+32 -5
Customize query in gerrit

Event Timeline

kostajh created this task.Wed, Dec 3, 8:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Dec 3, 8:26 AM
gerritbot added a comment.Wed, Dec 3, 8:30 AM

Change #1214447 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikimediaEvents@master] hCaptchaEditAttempt logging: Normalize line endings

https://gerrit.wikimedia.org/r/1214447

gerritbot added a project: Patch-For-Review.Wed, Dec 3, 8:30 AM
kostajh moved this task from Backlog to Needs review on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.Wed, Dec 3, 8:30 AM
kostajh moved this task from Backlog to In progress on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.
gerritbot added a comment.Wed, Dec 3, 10:10 AM

Change #1214447 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] hCaptchaEditAttempt logging: Normalize line endings

https://gerrit.wikimedia.org/r/1214447

gerritbot added a comment.Wed, Dec 3, 10:12 AM

Change #1214469 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.4] hCaptchaEditAttempt logging: Normalize line endings

https://gerrit.wikimedia.org/r/1214469

gerritbot added a comment.Wed, Dec 3, 10:12 AM

Change #1214470 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.5] hCaptchaEditAttempt logging: Normalize line endings

https://gerrit.wikimedia.org/r/1214470

gerritbot added a comment.Wed, Dec 3, 10:25 AM

Change #1214469 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.4] hCaptchaEditAttempt logging: Normalize line endings

https://gerrit.wikimedia.org/r/1214469

gerritbot added a comment.Wed, Dec 3, 10:26 AM

Change #1214470 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.5] hCaptchaEditAttempt logging: Normalize line endings

https://gerrit.wikimedia.org/r/1214470

Stashbot added a comment.Wed, Dec 3, 10:27 AM

Mentioned in SAL (#wikimedia-operations) [2025-12-03T10:27:03Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1214469|hCaptchaEditAttempt logging: Normalize line endings (T411578)]], [[gerrit:1214470|hCaptchaEditAttempt logging: Normalize line endings (T411578)]]

Stashbot added a comment.Wed, Dec 3, 10:29 AM

Mentioned in SAL (#wikimedia-operations) [2025-12-03T10:29:22Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1214469|hCaptchaEditAttempt logging: Normalize line endings (T411578)]], [[gerrit:1214470|hCaptchaEditAttempt logging: Normalize line endings (T411578)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Maintenance_bot removed a project: Patch-For-Review.Wed, Dec 3, 10:30 AM
Stashbot added a comment.Wed, Dec 3, 10:34 AM

Mentioned in SAL (#wikimedia-operations) [2025-12-03T10:34:59Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1214469|hCaptchaEditAttempt logging: Normalize line endings (T411578)]], [[gerrit:1214470|hCaptchaEditAttempt logging: Normalize line endings (T411578)]] (duration: 07m 56s)

kostajh moved this task from Needs review to Needs QA on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.Wed, Dec 3, 10:41 AM
kostajh moved this task from In progress to QA on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Wed, Dec 3, 11:00 AM
kostajh removed kostajh as the assignee of this task.Tue, Dec 9, 1:07 PM
kostajh moved this task from Needs QA to Ready on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.

Seems like this may still be an issue, so I'm moving it to ready, for investigation and follow-up fixes.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits