Page MenuHomePhabricator

Concatenation of several literal strings times out
Closed, DuplicatePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):
Turns out that the concatenation times out, even with very simple inputs:

https://www.wikifunctions.org/view/en/Z21394?call=%7B%22Z1K1%22%3A%22Z7%22%2C%22Z7K1%22%3A%22Z21394%22%2C%22Z21394K1%22%3A%5B%22Z6%22%2C%22a%22%2C%22f%22%2C%22c%22%2C%22d%22%5D%7D

That really shouldn't time out.

Original issue

What happens?:
It times out.

What should have happened instead?:
It shouldn't.

Here are the individual calls: the outside function Z26039 should delegate to the language appropriate function Z26617, and that one also times out:

https://www.wikifunctions.org/view/en/Z26617?call=%7B%22Z1K1%22%3A%22Z7%22%2C%22Z7K1%22%3A%22Z26617%22%2C%22Z26617K1%22%3A%7B%22Z1K1%22%3A%22Z6091%22%2C%22Z6091K1%22%3A%22Q3870%22%7D%2C%22Z26617K2%22%3A%7B%22Z1K1%22%3A%22Z6091%22%2C%22Z6091K1%22%3A%22Q515%22%7D%7D

The implementation is just a simple concatenation of strings: https://www.wikifunctions.org/view/en/Z26620

Two of the strings being concatenated are calling for Wikidata labels, but both of these are reasonably fast, a few 100ms:
https://www.wikifunctions.org/view/en/Z23753?call=%7B%22Z1K1%22%3A%22Z7%22%2C%22Z7K1%22%3A%22Z23753%22%2C%22Z23753K1%22%3A%7B%22Z1K1%22%3A%22Z6091%22%2C%22Z6091K1%22%3A%22Q3870%22%7D%2C%22Z23753K2%22%3A%22Z1272%22%7D

https://www.wikifunctions.org/view/en/Z23753?call=%7B%22Z1K1%22%3A%22Z7%22%2C%22Z7K1%22%3A%22Z23753%22%2C%22Z23753K1%22%3A%7B%22Z1K1%22%3A%22Z6091%22%2C%22Z6091K1%22%3A%22Q515%22%7D%2C%22Z23753K2%22%3A%22Z1272%22%7D

Turns out that the concatenation of all things, times out, even with very simple inputs:

https://www.wikifunctions.org/view/en/Z21394?call=%7B%22Z1K1%22%3A%22Z7%22%2C%22Z7K1%22%3A%22Z21394%22%2C%22Z21394K1%22%3A%5B%22Z6%22%2C%22a%22%2C%22f%22%2C%22c%22%2C%22d%22%5D%7D

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

DVrandecic renamed this task from "Nairobi je grad." (Nairobi is a city in Croatian) times out to Concatenation of several literal strings times out.Dec 3 2025, 11:03 AM
DVrandecic updated the task description. (Show Details)

I agree with Al, but for the last 3 days it has been a continuous and widespread breakage, even when python tech was reset. So I think it's important to have this new Phab report to focus everyone's attention.

Other clear examples:

There are less clear examples that are heavily impacted which basically stops all the very complex functions working, e.g.

Actually, some of those “passes” are “fails”; never trust an expected inequality!

Because T373607