Page MenuHomePhabricator
Create Task
Maniphest T411600

Clicking edit from a mobile diff causes bottom tray to remain visible in the editor
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Steps to reproduce

Screenshot 2025-12-05 at 14.42.24.png (296×872 px, 48 KB)

image.png (1×870 px, 399 KB)

The tray should only be visible while looking at a diff, and should never be visible when editing.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Clicking edit from a mobile diff causes bottom tray to remain visible in the editormediawiki/skins/MinervaNeuemaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwalton9-WMF created this task.Dec 3 2025, 11:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2025, 11:06 AM
Dillon added a parent task: T402297: It should be possible to undo edits on mobile.Dec 4 2025, 6:00 PM
jsn.sherman subscribed.Dec 4 2025, 6:00 PM

@Samwalton9-WMF I see the help panel in there; does this happen with the panel disabled?

Dillon edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.Dec 4 2025, 6:01 PM
Johannnes89 subscribed.Dec 4 2025, 6:37 PM
Samwalton9-WMF added a comment.Dec 5 2025, 10:43 AM
In T411600#11433754, @jsn.sherman wrote:

@Samwalton9-WMF I see the help panel in there; does this happen with the panel disabled?

Yes, just tested this on en.wiki, the help panel appears to be unrelated.

Samwalton9-WMF added a comment.EditedDec 5 2025, 10:44 AM

FWIW the URL of the page you get to when clicking edit on a diff is https://en.wikipedia.org/w/index.php?title=Pok%C3%A9mon_Red,_Blue,_and_Yellow&diff=prev&oldid=1325819762#/editor/0 as opposed to https://en.wikipedia.org/wiki/Pok%C3%A9mon_Red,_Blue,_and_Yellow#/editor/0

Kgraessle claimed this task.Dec 5 2025, 1:37 PM
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Kgraessle added a comment.Dec 5 2025, 2:09 PM

@Samwalton9-WMF

I cannot seem to reproduce this, do you mind adding more detailed reproducible steps?

However, while trying to reproduce this, I did notice on safari (on my phone) that the mobile version history view is cutting off content.
I can file a bug if this isn't a known one.

IMG_8386.PNG (2×1 px, 750 KB)

IMG_8387.PNG (2×1 px, 614 KB)

Kgraessle changed the task status from Open to Stalled.Dec 5 2025, 2:10 PM
Samwalton9-WMF updated the task description. (Show Details)Dec 5 2025, 2:42 PM
Samwalton9-WMF updated the task description. (Show Details)Dec 5 2025, 3:01 PM
gerritbot added a comment.Dec 5 2025, 5:18 PM

Change #1215659 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/skins/MinervaNeue@master] Clicking edit from a mobile diff causes bottom tray to remain visible in the editor

https://gerrit.wikimedia.org/r/1215659

gerritbot added a project: Patch-For-Review.Dec 5 2025, 5:18 PM
Kgraessle changed the task status from Stalled to Open.Dec 5 2025, 5:21 PM
Kgraessle triaged this task as High priority.
PatchDemoBot added a comment.Dec 5 2025, 6:24 PM

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://539c1ff75c.catalyst.wmcloud.org/w/

Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Dec 5 2025, 6:34 PM
Samwalton9-WMF set the point value for this task to 3.Dec 9 2025, 5:08 PM
Michael subscribed.Dec 12 2025, 12:19 PM
Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Dec 18 2025, 7:16 PM
gerritbot added a comment.Dec 18 2025, 7:37 PM

Change #1215659 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Clicking edit from a mobile diff causes bottom tray to remain visible in the editor

https://gerrit.wikimedia.org/r/1215659

Maintenance_bot removed a project: Patch-For-Review.Dec 18 2025, 8:31 PM
Dillon closed this task as Resolved.Thu, Jan 8, 5:43 PM
Dillon moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits