Page MenuHomePhabricator

Add HTML IDs for each module at the Growth Homepage
Closed, ResolvedPublic

Description

Based on this feedback. from Mathglot.

The idea is to have a proper way to highlight a Growth Homepage module to a mentee, for instance in a template or in a response.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I like this idea, but I'm unclear on the technical effort to implement it.

I wonder if it makes sense to work on this before we have a final plans for how the Homepage and Dashboard connect. T402647: Launch new moderator homepage MVP / https://www.mediawiki.org/wiki/Moderator_Tools/Dashboard

Change #1233184 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] feat(DashboardModule): Add IDs to module wrappers

https://gerrit.wikimedia.org/r/1233184

This makes a lot of sense to me! We have classes to easily identify the module (for styling in CSS, such as growthexperiments-homepage-module-community-updates), but we haven't thought about anchor links (for which the IDs are the only way). This should be a straightforward change in DashboardModule::buildModuleWrapper().

Change #1233184 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] feat(DashboardModule): Add IDs to module wrappers

https://gerrit.wikimedia.org/r/1233184

Change #1233202 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup(BaseModule): Remove unused code

https://gerrit.wikimedia.org/r/1233202

Change #1233202 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup(BaseModule): Remove unused code

https://gerrit.wikimedia.org/r/1233202

Etonkovidova claimed this task.
Etonkovidova subscribed.

Checked on testwiki wmf.15 and enwiki wmf.15 - id's are added, e.g.

div id="growthexperiments-homepage-module-mentorship"
div id="growthexperiments-homepage-module-help"

Thanks for this! Are the two ids above the only ones that were added? What about the Suggested Edits module?