- Go to https://www.wikifunctions.org/view/en/Z28931
- Click the 'Details' link for one of the results
- Meta-data dialog appears but missing the close button (Escape still works)
Description
Description
Details
Details
Related Changes in Gerrit:
Event Timeline
Comment Actions
Change #1215205 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):
[mediawiki/extensions/WikiLambda@master] CdxDialog: use-close-button prop needs to be set to true
Comment Actions
I think this may have been caused by Codex 2.3.3 which is new this release (wmf.5) — looking at the changelog shows some entries around the close button control. Ah well.
Comment Actions
Change #1215205 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] CdxDialog: use-close-button prop needs to be set to true
Comment Actions
Change #1215224 had a related patch set uploaded (by Jforrester; author: Daphne Smit):
[mediawiki/extensions/WikiLambda@wmf/1.46.0-wmf.5] CdxDialog: use-close-button prop needs to be set to true
Comment Actions
Sorry about this -- the reason this broke is because we changed the way we hide the close button from using v-if to using CSS. The previous way (v-if) didn't affect you because you override the header with a custom one so we don't render our own close button regardless. The new way (CSS) did affect you, because your close button in your custom header uses the same CSS class as our built-in one.
Comment Actions
Change #1215224 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@wmf/1.46.0-wmf.5] CdxDialog: use-close-button prop needs to be set to true