UploadWizard structure tests fail when EventLogging is not loaded
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Dec 3 2025, 6:23 PM

Description

When running structure tests for UploadWizard , tests fail due to lack of the MediaWiki-extensions-EventLogging extension:

1) ContentHandlerFunctionalTest::testMakeEmptyContent
Error: Class "MediaWiki\Extension\EventLogging\EventLogging" not found

extensions/UploadWizard/includes/CampaignContent.php:59
extensions/UploadWizard/includes/CampaignContent.php:67
core/tests/phpunit/structure/ContentHandlerFunctionalTest.php:43

2) ContentHandlerFunctionalTest::testGetParserOutput
Error: Class "MediaWiki\Extension\EventLogging\EventLogging" not found

extensions/UploadWizard/includes/CampaignContent.php:59
extensions/UploadWizard/includes/CampaignContent.php:67
core/includes/Parser/ParserObserver.php:54
core/includes/Content/ContentHandler.php:1581
core/tests/phpunit/structure/ContentHandlerFunctionalTest.php:67

3) ContentHandlerFunctionalTest::testPreSaveTransform
Error: Class "MediaWiki\Extension\EventLogging\EventLogging" not found

extensions/UploadWizard/includes/CampaignContent.php:59
extensions/UploadWizard/includes/CampaignContent.php:67
core/includes/Content/JsonContentHandler.php:99
core/tests/phpunit/structure/ContentHandlerFunctionalTest.php:91

https://www.mediawiki.org/wiki/Extension:UploadWizard states:

You should also install the EventLogging extension.

This is used only if you use the campaigns feature, and should be made a soft dependency at some point in the future.

Surely if I remove the content handler in extension.json:

{
    "ContentHandlers": { 
        "Campaign": "MediaWiki\\Extension\\UploadWizard\\CampaignContentHandler"
    },
}

The tests pass since the content handler no more exists. Maybe it could be registered solely when EventLogging is present.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Zuul: [UploadWizard] disable recursion	integration/config	master	+7 -3
	Only register content handler when EventLogging is loaded	mediawiki/extensions/UploadWizard	master	+23 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T391008 Reconcile dependencies.yaml and phan_dependencies.yaml
Open	hashar	T389998 Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout)
Open	hashar	T407797 Create a CI job to enforce tests to pass with solely required extensions
Open	None	T410045 MinervaNeue QUnit tests fail when MobileFrontend is not present
Open	None	T410051 Babel tests fail when CommunityConfiguration is not present
Open	None	T410053 ArticlePlaceholder tests fail when Wikibase is not present
Open	None	T410056 EventBus tests fail without EventStreamConfig
Open	None	T410057 Newsletter tests fail without Echo extension
Open	None	T410117 ReportIncident PHPUnit tests fail when CommunityConfiguration is not present
Open	None	T412861 CommunityConfiguration structured test should only introduce a soft test-time dependency
Resolved	hashar	T410118 TheWikipediaLibrary extension tests fail when Echo is not present
Open	hashar	T410119 WikimediaBadges tests fail when WikibaseClient is not loaded
Open	hashar	T410122 Tests depending on EventBus fail when EventStreamConfig is not loaded
Resolved	hashar	T410126 WikimediaEvents tests fail when ConfirmEdit is not loaded
Resolved	DAlangi_WMF	T410129 OAuth tests are failing when no other extension is loaded
Resolved	mszwarc	T410132 IPInfo tests are failing when no other extension is loaded
Resolved	hashar	T411644 UploadWizard QUnit tests failing mw.uploadWizard.controller.Deed: Died on test #1: can't access property "top", offset is undefined
Resolved	hashar	T411660 UploadWizard structure tests fail when EventLogging is not loaded
Resolved	Ammarpad	T413718 Automoderator tests fail when CommunityConfiguration is not present

Event Timeline

hashar created this task.Dec 3 2025, 6:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2025, 6:23 PM

hashar added parent tasks: T407797: Create a CI job to enforce tests to pass with solely required extensions, T389998: Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout).Dec 3 2025, 6:23 PM

Change #1214625 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/UploadWizard@master] Only register content handler when EventLogging is loaded

https://gerrit.wikimedia.org/r/1214625

gerritbot added a project: Patch-For-Review.Dec 3 2025, 8:00 PM

UploadWizard uses EventLogging to validate content on a wiki page against a schema. The Experiment Platform team would very much prefer this not to be the case (see T317793: [EPIC] Deprecate EventLogging::schemaValidate()). I would be happy to work with the maintainers of the extension to use the justinrainbow/json-schema or opis/json-schema libraries for this, both of which are used in production.

hashar mentioned this in T411644: UploadWizard QUnit tests failing mw.uploadWizard.controller.Deed: Died on test #1: can't access property "top", offset is undefined.Mon, Dec 15, 11:35 AM

@phuedx UploadWizard does not have a maintainer anymore after the Structured Content team has been disbanded. Your team might want to handle the removal of EventLogging:schemaValidate() ;)

Change #1214625 abandoned by Hashar:

[mediawiki/extensions/UploadWizard@master] Only register content handler when EventLogging is loaded

Reason:

Sam Smith mentioned we should instead remove `EventLogging:schemaValidate()` T411660#11436326. That is tracked by the epic T317793

https://gerrit.wikimedia.org/r/1214625

Change #1224684 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Zuul: [UploadWizard] disable recursion

https://gerrit.wikimedia.org/r/1224684

Change #1224684 merged by jenkins-bot:

[integration/config@master] Zuul: [UploadWizard] disable recursion

https://gerrit.wikimedia.org/r/1224684

The UploadWizard tests failed for EncryptedUploads and PronunciationRecording. They both depend on UploadWizard but did not have EventLogging injected.

Short of making the tests skippable, I have simply added EventLogging as a dependency to both EncryptedUploads and PronunciationRecording. I have confirmed the CI jobs pass as a result which resolves this task.

EventLogging:schemaValidate() should still be removed, that should be a new sub task of T317793 😉

Maintenance_bot removed a project: Patch-For-Review.Thu, Jan 8, 2:30 PM

UploadWizard structure tests fail when EventLogging is not loadedClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

UploadWizard structure tests fail when EventLogging is not loaded
Closed, ResolvedPublic
Actions

Related Objects
Search...