Page MenuHomePhabricator

Consider splitting up Edit Check config
Open, Needs TriagePublic

Description

Some checks are going to contain lots of data (text match checks, British/American English mapping), so they having a monolithic file for all check configuration is going to get messy.

Fragmenting our config may make that config less discoverable though, so we should consider how we maintain that discoverability (e.g. a new special page to indexes all config).

Requirements

  • Support matchItem configurations that live in separate files. That is, for any object in the array of matchItems (MediaWiki:Editcheck-config.json -> textMatch -> matchItems) that has the import key, TextMatch should load the corresponding file (as specified by the import value) and use it as that matchItem's config.
  • Create a Special page to view a summary of current editcheck configurations.

Event Timeline

Change #1215130 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Introduce Special:EditChecks

https://gerrit.wikimedia.org/r/1215130

Change #1217319 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] WIP: prototype a community config page for enabling edit checks

https://gerrit.wikimedia.org/r/1217319

Change #1219952 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] EditCheck: split up configs

https://gerrit.wikimedia.org/r/1219952

Change #1215130 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Introduce Special:EditChecks

https://gerrit.wikimedia.org/r/1215130

Update on where we're at:

  • (merged) To maintain the discoverability of the configs, we have a Special:Edit Checks page.
  • (WIP) To avoid a messy, monolithic config file, we decided on pulling out just the TextMatch config (which would likely to contribute to most of the messiness, given its potential for long word lists) and add a way to load matchitems from external messages.