Page MenuHomePhabricator

Visual diff shows all links as changed after switching from section editing to full page editing
Open, Needs TriagePublic

Description

  1. Enable $wgVisualEditorEnableSectionEditingFullPageButtons
  2. Open a multi-section page in one section
  3. Edit that section
  4. Switch to full page using an "Edit full page" button
  5. View the visual diff (Publish changes... -> Show changes)

Observe that every link in every other section of the document is shown as removed and inserted.

Event Timeline

It looks like the links in the "new" document aren't being sanitized and having their data-parsoid id's removed, so <a href="..."> !== <a id="mw..." href="...">

Could you provide a minimal example of a page that breaks? I've been having trouble reproducing this.

Let's confirm this issue is still happening before we move forward with deploying the new Edit full page button.

Reason: this issue sounds like it would lead people to mistakenly perceive the changes they've made being broader than they had thought.

It happens locally, but not in production (so I suspect this is something to do with Parsoid config).

This is still a valid bug, but if it isn't affecting WMF production wikis it's much lower priority.

@Esanders per T411664#11593874, I'm going to assume this issue is not live in production and accordingly, low priority for now.