Page MenuHomePhabricator

Adjust transition upon tapping "Edit full page"
Closed, ResolvedPublic

Description

This ticket involves the work of deciding how we will adjust the current scroll transition (50% of viewport) so that upon tapping the Edit full page button T409112 introduces, people will:

  1. Become clear more content is now available for them to edit
  2. Retain an understanding of "where" they are in relation to where they had been focused immediately before tapping the button

Decision(s) to be made

Approaches

Done

  • 130px scroll (~15%) is implemented
  • Over-scrolling bug is fixed; see Slack

Event Timeline

Per offline discussions, we're going to move forward with the 130 px / 15% scroll approach.

Thinking:

  1. People will find a nominal scroll familiar for it is consistent with what would've happened when they initially tapped an Edit button to arrive into the editing interface
  2. A nominal scroll will both a) make clear to people that more content is available for them to see/edit and b) enable people to feel grounded for what they are likely to have been looking edit prior to tapping Edit full page will still be in view

Change #1214608 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Set full page scroll to 130px

https://gerrit.wikimedia.org/r/1214608

The scroll jump is caused by images lazy-loading in the section above. Minerva has a rule that makes images responsive, but we don't want to apply that in VE.

Change #1215619 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Ensure images are fixed size on mobile while loading

https://gerrit.wikimedia.org/r/1215619

Change #1214608 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Set full page scroll to 130px

https://gerrit.wikimedia.org/r/1214608

Change #1215619 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Ensure images are fixed size on mobile while loading

https://gerrit.wikimedia.org/r/1215619

Change #1216611 had a related patch set uploaded (by DLynch; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.5] Set full page scroll to 130px

https://gerrit.wikimedia.org/r/1216611

Change #1216612 had a related patch set uploaded (by DLynch; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.5] Ensure images are fixed size on mobile while loading

https://gerrit.wikimedia.org/r/1216612

Change #1216611 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.5] Set full page scroll to 130px

https://gerrit.wikimedia.org/r/1216611

Change #1216612 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.5] Ensure images are fixed size on mobile while loading

https://gerrit.wikimedia.org/r/1216612

Mentioned in SAL (#wikimedia-operations) [2025-12-08T21:16:47Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1216608|Add instrumentation for mobile section switching (T410319)]], [[gerrit:1216609|Edit full page: Tweak skeleton appearance and fix scroll offsets]], [[gerrit:1216611|Set full page scroll to 130px (T411669)]], [[gerrit:1216612|Ensure images are fixed size on mobile while loading (T411669)]]

Mentioned in SAL (#wikimedia-operations) [2025-12-08T21:18:40Z] <urbanecm@deploy2002> kemayo, urbanecm: Backport for [[gerrit:1216608|Add instrumentation for mobile section switching (T410319)]], [[gerrit:1216609|Edit full page: Tweak skeleton appearance and fix scroll offsets]], [[gerrit:1216611|Set full page scroll to 130px (T411669)]], [[gerrit:1216612|Ensure images are fixed size on mobile while loading (T411669)]] synced to the testservers (see https://wikitech.wikimedia.org/w

Mentioned in SAL (#wikimedia-operations) [2025-12-08T21:24:24Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1216608|Add instrumentation for mobile section switching (T410319)]], [[gerrit:1216609|Edit full page: Tweak skeleton appearance and fix scroll offsets]], [[gerrit:1216611|Set full page scroll to 130px (T411669)]], [[gerrit:1216612|Ensure images are fixed size on mobile while loading (T411669)]] (duration: 07m 36s)

Tested in enwiki, enbeta, frwiki, hewiki, zhwiki,enwikitionary for lead, middle, and last sections.

image.png (1×676 px, 111 KB)

image.png (1×664 px, 109 KB)

image.png (1×656 px, 77 KB)