Page MenuHomePhabricator
Create Task
Maniphest T411676

Associating a label with a MW SelectWithInputWidget does not work
Closed, ResolvedPublic
Actions

Description

I tried fixing the issue noted in T410845#11417887. This did not get rid of the warning in Firefox's accessibility inspector, nor did it work in practice with a screen reader: the label is associated with the wrapper element of the select and the input, instead of individually with each of them.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
SelectWithInputWidget: Improve 'aria-labelledby' attributesmediawiki/coremaster+24 -0
Update OOUI to v0.53.1mediawiki/coremaster+248 -92
TabIndexedElement: Provide a default setLabelledBy() methodoojs/uimaster+29 -0
Customize query in gerrit

Related Objects

Event Timeline

• matmarex created this task.Dec 3 2025, 8:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2025, 8:35 PM
• matmarex mentioned this in T410845: Userrights special pages layout requires excessive scrolling.Dec 3 2025, 8:35 PM
gerritbot added a comment.Dec 3 2025, 8:36 PM

Change #1214634 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[oojs/ui@master] TabIndexedElement: Provide a default setLabelledBy() method

https://gerrit.wikimedia.org/r/1214634

gerritbot added a project: Patch-For-Review.Dec 3 2025, 8:36 PM
gerritbot added a comment.Dec 3 2025, 8:41 PM

Change #1214635 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] SelectWithInputWidget: Improve 'aria-labelledby' attributes

https://gerrit.wikimedia.org/r/1214635

• matmarex claimed this task.Dec 3 2025, 8:44 PM
• matmarex added a project: OOUI.
PatchDemoBot added a comment.Dec 3 2025, 8:51 PM

Test wiki created on Patch demo by Matma Rex using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/0f6a7b20b9/wiki/Special:UserLogin?returnto=Special:UserRights/Patch Demo

Also created an OOUI Demos page:
https://patchdemo.wmcloud.org/wikis/0f6a7b20b9/w/build/ooui/demos

gerritbot added a comment.Dec 3 2025, 10:48 PM

Change #1214634 merged by jenkins-bot:

[oojs/ui@master] TabIndexedElement: Provide a default setLabelledBy() method

https://gerrit.wikimedia.org/r/1214634

Volker_E added a project: Accessibility.Dec 3 2025, 11:26 PM
gerritbot added a comment.Dec 18 2025, 9:55 PM

Change #1219646 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.53.1

https://gerrit.wikimedia.org/r/1219646

gerritbot added a comment.Dec 18 2025, 11:37 PM

Change #1219646 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.53.1

https://gerrit.wikimedia.org/r/1219646

gerritbot added a comment.Dec 20 2025, 12:35 AM

Change #1214635 merged by jenkins-bot:

[mediawiki/core@master] SelectWithInputWidget: Improve 'aria-labelledby' attributes

https://gerrit.wikimedia.org/r/1214635

Maintenance_bot removed a project: Patch-For-Review.Dec 20 2025, 1:30 AM
Volker_E closed this task as Resolved.Dec 20 2025, 2:11 AM
PatchDemoBot added a comment.Dec 20 2025, 2:25 AM

Test wiki on Patch demo by Matma Rex using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/0f6a7b20b9/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits