Page MenuHomePhabricator

Donation form sticky if back button used
Closed, ResolvedPublic

Description

As mentioned on slack (related thread) donor in #1786204 / CID 17773992 reported:

"Unfortunately, I did not sign up for the $3/month donation plan. I authorized a single $15 donation and not a monthly donation.
What happened click by click:
I selected a one-time $15 donation
Two buttons appeared and I accidentally clicked the lower one
I was sent to a page citing a $3/month plan asking for authorization
I did not authorize because this was a mis-click
I used the back button to return to the prior page
I clicked the one-time $15 gift button
I authorized the $15 transaction
I was sent to a confirmation page for the $3 transaction, which is not what I authorized

Hopefully you can see the error. I corrected my selection but the system ignored this and authorized the wrong selection."

Per contribution tracking in Civi their donation was made from a banner using Chrome via PayPal. I attempt to locate the banner and while I don't believe I located the exact banner I was able to recreate it from a different one.

  1. Using incognito on Chrome going to https://en.wikipedia.org/wiki/Wikipedia?useformat=desktop&country=US&banner=B2526_120220_en6C_dsk_p1_lg_cvt_mcDialog
  2. Select an amount and choose PayPal
  3. In the monthly convert select Yes to monthly
  4. Change your mind and go backwards before you're taken to PayPal
  5. Select one-time in the pop-up instead
  6. Still says monthly before it takes you to Paypal as shown in the screenshot below.

SS 1 12032025.png (640×733 px, 73 KB)

Note: When I tried to recreate this in regular browsing mode on Chrome from the same exact link I just got an immediate error which I assumed indicated I was just blocked, but I'm unclear on that bit.

SS 2 12032025.png (549×1 px, 60 KB)

The form stickiness we have encountered before in https://phabricator.wikimedia.org/T403206 and https://phabricator.wikimedia.org/T313969 seems like donation form is just a bit sticky at times. :)

Event Timeline

Pcoombe subscribed.

I have an idea what this is, will look into it

Okay, this should be fixed in banners now: example, change made. It was an issue even before we switched to the monthly convert dialogs, but maybe that made it a bit more obvious.

I would like to overhaul how the banner monthlyconvert code works more generally, at the moment it's quite confusing which leads to issues like this. But that will have to wait until there's more time.