Page MenuHomePhabricator
Create Task
Maniphest T411702

Allow the user to configure the language of the rendered article preview
Closed, ResolvedPublic
Actions

Description

Description

Readers or editors of an Abstract content page should be able to change the language that the Abstract Preview is being rendered for, independently from the page language.

Desired behavior/Acceptance criteria

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Preview: add language selector for the abstract previewmediawiki/extensions/WikiLambdamaster+229 -91
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Dec 3 2025, 9:58 PM
Jdforrester-WMF moved this task from To Triage to 26Q3 (Jan–Mar) on the Abstract Wikipedia team board.Dec 9 2025, 8:25 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q3 (Jan–Mar)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Dec 9 2025, 8:28 PM
Jdforrester-WMF triaged this task as Medium priority.Dec 9 2025, 8:31 PM
gengh renamed this task from Allow the user changing the page language to change that used for rendering the auto-article to Allow the user to configure the language of the rendered article preview.Feb 12 2026, 11:18 AM
gengh updated the task description. (Show Details)
DSmit-WMF subscribed.EditedFeb 12 2026, 12:07 PM

Implementation details:

Fragment preview cache will be keyed by (keyPath + language) to support multiple cached languages. When switching the language selector back to a language selected before, therefor the preview will show instantly.

Abstract store (abstractWiki.js)

  • Add previewLanguageZid to state
  • Add getter getPreviewLanguageZid
  • Returns previewLanguageZid OR getUserLangZid
  • Add action setPreviewLanguageZid(zid)
  • Initialize preview language to page language

Fragment cache changes
We are talking about state.fragments[keypath] currently.

  • Change fragment cache key to keyPath|language
  • Update all helpers to use composite key: getFragmentPreview, renderFragmentPreview, etc

AbstractPreview.vue

  • Header label: use getPreviewLanguageZid instead of getUserLangZid
  • Add language selector in header-action
  • Use ZObjectSelector with type=Z_NATURAL_LANGUAGE. On select → call setPreviewLanguageZid

NB: I wonder if this is how we want to fetch the languages?

AbstractPreviewFragment.vue

  • Pass language: getPreviewLanguageZid to renderFragmentPreview
  • Continue reading via getFragmentPreview(keyPath) (store resolves correct language key)
  • Existing watchers should trigger re-render on language change (no new watcher required)

Acceptance Criteria

  • Preview defaults to page language
  • User can change preview language via selector
  • Preview re-renders in selected language
  • Fragment cache is language-aware
  • Currently selected language is excluded from selector options
DSmit-WMF changed the task status from Open to In Progress.Feb 12 2026, 12:07 PM
DSmit-WMF claimed this task.
DSmit-WMF moved this task from Ready to In Engineering on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.
DSmit-WMF added a comment.EditedFeb 12 2026, 1:05 PM

open questions

  • Should we translate the error (not sure how havent looked into it)? Maybe not as part of this scope.
  • Do we want to reuse the zobject selector here with Z60 as input? or a different selector
  • I feel like the zobject selector or lookup has a bug, whenever I try to change the page language to something else then english and clear the language selector -> the suggestions never show up, only until I have chosen a different language . I checked and this is because the lookup expects the selectedItem to be inside the menuItems, which is not the case with the suggested items. so this is a bug. We probably need to reset the selecteditem

Is the following like we want it?

language-abstract-preview (1).mov3 MBDownload
Demo video
gerritbot added a comment.Feb 12 2026, 4:11 PM

Change #1239152 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Preview: add language selector for the abstract preview

https://gerrit.wikimedia.org/r/1239152

gerritbot added a project: Patch-For-Review.Feb 12 2026, 4:11 PM
DSmit-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Feb 12 2026, 4:12 PM
gerritbot added a comment.Feb 17 2026, 3:07 PM

Change #1239152 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Preview: add language selector for the abstract preview

https://gerrit.wikimedia.org/r/1239152

Maintenance_bot removed a project: Patch-For-Review.Feb 17 2026, 3:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.17; 2026-02-24).Feb 17 2026, 4:00 PM
DSmit-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.Feb 18 2026, 10:41 AM
Jdforrester-WMF closed this task as Resolved.Feb 18 2026, 11:07 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q3 (Jan–Mar)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits