Page MenuHomePhabricator
Create Task
Maniphest T411769

Migrate wikifeeds backend calls away from rest-gateway
Closed, ResolvedPublic
Actions

Description

rest-gateway is meant for centralized routing of external API calls and should not be called by services running inside production.

Wikifeeds calls it for a couple of functions in pageviews.js:

and maybe in other places.

Would it be possible to change that to calling the page-analytics service via the service mesh?

Details

Other Assignee
Clement_Goubert
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Replace calls to rest-gateway with direct Analytics API callsmediawiki/services/wikifeedsmaster+15 -17
wikifeeds: Add request definition for page analyticsoperations/deployment-chartsmaster+12 -1
service mesh: Add page-analytics listeneroperations/puppetproduction+7 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Clement_Goubert created this task.Dec 4 2025, 12:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2025, 12:06 PM
Clement_Goubert added a parent task: T410198: Determine the source of internal requests going through the API gateway..Dec 4 2025, 12:07 PM
Clement_Goubert added a project: Content-Transform-Team.Dec 4 2025, 12:10 PM
Clement_Goubert added a parent task: T411641: Fix external calls to AQS in Wikimedia extensions.Dec 4 2025, 1:12 PM
• Tgr subscribed.Dec 4 2025, 1:14 PM

Doesn't it use these values in production? I think that would be the service mesh?

Clement_Goubert added a comment.EditedDec 4 2025, 1:27 PM

Yes but it calls restGatewayGet which routes through the rest-gateway instead of using the mesh for page-analytics to reach AQS

MSantos added a project: Essential-Work.Dec 4 2025, 3:07 PM
MSantos moved this task from Backlog to Later on the Content-Transform-Team board.
Jgiannelos claimed this task.Dec 22 2025, 11:17 AM
Jgiannelos edited projects, added Content-Transform-Team (Work In Progress); removed Content-Transform-Team.
gerritbot added a comment.Dec 23 2025, 10:58 AM

Change #1220621 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/services/wikifeeds@master] Replace calls to rest gateway with direct Analytics API calls

https://gerrit.wikimedia.org/r/1220621

gerritbot added a project: Patch-For-Review.Dec 23 2025, 10:58 AM
Jgiannelos moved this task from Backlog to To Deploy on the Content-Transform-Team (Work In Progress) board.Dec 23 2025, 11:04 AM
Jgiannelos moved this task from To Deploy to Code Review on the Content-Transform-Team (Work In Progress) board.
gerritbot added a comment.Dec 23 2025, 12:53 PM

Change #1220629 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[operations/deployment-charts@master] wikifeeds: Add request definition for page analytics

https://gerrit.wikimedia.org/r/1220629

Jgiannelos added a comment.Dec 23 2025, 3:13 PM

I submitted a few patches to switchover from rest-gateway calls to page-analytics but i am not sure whether page-analytics is exposed in service mesh.
From a quick look here it looks like it isn't:
https://gerrit.wikimedia.org/g/operations/puppet/+/ce60f68445c5e474fc12257f9c131e1231b5d985/hieradata/common/profile/services_proxy/envoy.yaml#386

Jgiannelos added a comment.Feb 3 2026, 5:26 PM

@Clement_Goubert Can you help me figure out which endpoint wikifeeds should be pointed to, so we stop using rest-gateway directly ?

Jgiannelos moved this task from Code Review to Blocked on the Content-Transform-Team (Work In Progress) board.Feb 9 2026, 4:19 PM
Clement_Goubert triaged this task as Medium priority.Feb 19 2026, 3:09 PM
Clement_Goubert edited projects, added ServiceOps new, ServiceOps-SharedInfra; removed serviceops-radar.
Clement_Goubert moved this task from Inbox to Scheduled (this Q) on the ServiceOps new board.

Yup, will take a look soon, sorry I dropped the ball on this.

Clement_Goubert updated Other Assignee, added: Clement_Goubert.Feb 19 2026, 3:11 PM
gerritbot added a comment.Feb 20 2026, 11:03 AM

Change #1240888 had a related patch set uploaded (by Clément Goubert; author: Clément Goubert):

[operations/puppet@production] service mesh: Add page-analytics listener

https://gerrit.wikimedia.org/r/1240888

gerritbot added a comment.Feb 23 2026, 12:36 PM

Change #1240888 merged by Clément Goubert:

[operations/puppet@production] service mesh: Add page-analytics listener

https://gerrit.wikimedia.org/r/1240888

Clement_Goubert added a comment.Mon, Mar 23, 2:38 PM

I've applied the fix with the correct port to https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1220629 so everything should be good for you to proceed once it's been +1'd and deployed.

Clement_Goubert moved this task from Scheduled (this Q) to Radar (Awareness) on the ServiceOps new board.Mon, Mar 23, 2:38 PM
gerritbot added a comment.Tue, Apr 7, 1:57 PM

Change #1220629 merged by jenkins-bot:

[operations/deployment-charts@master] wikifeeds: Add request definition for page analytics

https://gerrit.wikimedia.org/r/1220629

SLopes-WMF moved this task from Blocked to Code Review on the Content-Transform-Team (Work In Progress) board.Tue, Apr 7, 2:49 PM
gerritbot added a comment.Wed, Apr 15, 6:21 AM

Change #1220621 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] Replace calls to rest-gateway with direct Analytics API calls

https://gerrit.wikimedia.org/r/1220621

Maintenance_bot removed a project: Patch-For-Review.Wed, Apr 15, 6:30 AM
Jgiannelos moved this task from Code Review to To Deploy on the Content-Transform-Team (Work In Progress) board.Wed, Apr 15, 2:34 PM
Jgiannelos closed this task as Resolved.Wed, Apr 15, 3:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits