Page MenuHomePhabricator

Handle invalid featured collection name
Open, In Progress, HighPublic

Description

When a featured collection is nominated for a target wiki but the collection name doesn't correspond to any know collection, the CX dashboard features related to featured collection should treat this case the same way as if no featured collection is set.

Below is the updated version with AC1–AC3 consolidated into a single acceptance criterion, while keeping all formatting and guidelines intact.


Derived Requirement

Ensure that when a featured collection is nominated for a target wiki but the configured collection name does not correspond to any known collection, the Content Translation (CX) dashboard treats this scenario identically to having no featured collection configured, without errors, degraded UI, or altered suggestion behavior.

Test Steps

Test Case 1: Treat Invalid Featured Collection Name as No Featured Collection

Preconditions

  • A featured collection is nominated for the target wiki.
  • The nominated featured collection name does not match any existing or known collection.
  1. Open Wikipedia using the Minerva skin.
  2. Navigate to the CX dashboard for the target wiki.
  3. Allow the dashboard to load featured content and related suggestions.
  4. Observe the featured collection section and associated UI elements.
  5. ✅❓❌⬜ AC1: Confirm that no featured collection is displayed, the CX dashboard behaves as if no featured collection is configured, and no errors, warnings, or broken UI elements are shown.

QA Results - TestWiki

ACStatusDetails
1T411779#11503987

Event Timeline

eamedina changed the task status from Open to In Progress.Dec 4 2025, 1:58 PM
eamedina claimed this task.
eamedina moved this task from Prioritized to In-progress on the LPL Hypothesis board.

Change #1215662 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] Validate user provided featured collection name

https://gerrit.wikimedia.org/r/1215662

Change #1215662 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Validate user provided featured collection name

https://gerrit.wikimedia.org/r/1215662

Change #1216835 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+2025120

https://gerrit.wikimedia.org/r/1216835

Change #1217181 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@wmf/1.46.0-wmf.5] CX3 Build 1.0.0+20251209

https://gerrit.wikimedia.org/r/1217181

Change #1216835 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20251209

https://gerrit.wikimedia.org/r/1216835

Change #1217181 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.46.0-wmf.5] CX3 Build 1.0.0+20251209

https://gerrit.wikimedia.org/r/1217181

Mentioned in SAL (#wikimedia-operations) [2025-12-10T14:04:56Z] <sbisson@deploy2002> Started scap sync-world: Backport for [[gerrit:1217181|CX3 Build 1.0.0+20251209 (T384485 T408845 T409332 T409337 T409338 T411779)]]

Mentioned in SAL (#wikimedia-operations) [2025-12-10T14:07:02Z] <sbisson@deploy2002> sbisson: Backport for [[gerrit:1217181|CX3 Build 1.0.0+20251209 (T384485 T408845 T409332 T409337 T409338 T411779)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-12-10T14:13:57Z] <sbisson@deploy2002> Finished scap sync-world: Backport for [[gerrit:1217181|CX3 Build 1.0.0+20251209 (T384485 T408845 T409332 T409337 T409338 T411779)]] (duration: 09m 01s)

Change #1217504 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Wait for collection groups before resolving featured collection promise

https://gerrit.wikimedia.org/r/1217504

Change #1217504 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Wait for collection groups before resolving featured collection promise

https://gerrit.wikimedia.org/r/1217504

Change #1218297 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20251215

https://gerrit.wikimedia.org/r/1218297

Change #1218297 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20251215

https://gerrit.wikimedia.org/r/1218297

Change #1218762 had a related patch set uploaded (by Sbisson; author: Eamedina):

[mediawiki/extensions/ContentTranslation@wmf/1.46.0-wmf.5] CX3 Build 1.0.0+20251215

https://gerrit.wikimedia.org/r/1218762

Change #1218762 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.46.0-wmf.5] CX3 Build 1.0.0+20251215

https://gerrit.wikimedia.org/r/1218762

Mentioned in SAL (#wikimedia-operations) [2025-12-16T14:39:56Z] <sbisson@deploy2002> Started scap sync-world: Backport for [[gerrit:1218762|CX3 Build 1.0.0+20251215 (T408842 T411779)]]

Mentioned in SAL (#wikimedia-operations) [2025-12-16T14:42:15Z] <sbisson@deploy2002> sbisson: Backport for [[gerrit:1218762|CX3 Build 1.0.0+20251215 (T408842 T411779)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-12-16T14:47:24Z] <sbisson@deploy2002> Finished scap sync-world: Backport for [[gerrit:1218762|CX3 Build 1.0.0+20251215 (T408842 T411779)]] (duration: 07m 27s)

@eamedina Please review AC1, specifically mobile, since I'm getting an uncaught type error, but not on the Desktop.

**//UPDATE://** Pass per T411779#11503987

Test Result - Test Wiki

Status: ✅ PASS
Environment: Test Wiki
OS: macOS Tahoe 26.1
Browser: Chrome 143
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&active-list=suggestions&filter-id=collections&filter-type=automatic&from=ha&to=en#/

Test Steps

Test Case 1: Treat Invalid Featured Collection Name as No Featured Collection

Preconditions

  • A featured collection is nominated for the target wiki.
  • The nominated featured collection name does not match any existing or known collection.
  1. Open Wikipedia using the Minerva skin.
  2. Navigate to the CX dashboard for the target wiki.
  3. Allow the dashboard to load featured content and related suggestions.
  4. Observe the featured collection section and associated UI elements.
  5. AC1: Confirm that no featured collection is displayed, the CX dashboard behaves as if no featured collection is configured, and no errors, warnings, or broken UI elements are shown.
DesktopMobile

Thanks @GMikesell-WMF, I tested from my side again and I'm not able to replicated the type error. Either way, it seems the error you saw is unrelated to the scope of this task so I think it's safe to move it forward.

Ok sounds good! I will move it along, thanks!

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.