Page MenuHomePhabricator

CentralNotice config changes to show a banner to a reader with the 'waitdate: close' status
Closed, ResolvedPublic

Description

Hi @Ejegg, creating this task as requested > you were going to take the step of figuring out how we could tweak CentralNotice's code to enable us to show a fresh fundraising banner impression to readers who have clicked the Close button in a banner, and are therefore producing a CentralNotice status code of 2.1, banner_canceled due to close.

As this chart of status codes for yesterday shows, we can see that many readers aren't seeing banners due to status 2.1. We'd like the option of resurfacing banners to them, particularly since many people may still have a close cookie from our last pre-tests or Day 1 launch on Monday.

Screenshot 2025-12-04 at 11.36.25 AM.png (1×1 px, 111 KB)

Event Timeline

Adding @Pcoombe for visibility too, as the person who has maintained our core banner JS!

The cookie itself has a long expiration date but includes the created timestamp and the reason in the cookie body. Then we look up the duration for that reason in the $wgNoticeCookieDurations config variable and check to see if that much time has elapsed since the creation timestamp.

Here's the current value of $wgNoticeCookieDurations:

[
        'close' => 604800, // 1 week
        'donate' => 21600000, // 250 days
];

We can change it and deploy the change during one of the 'backport windows' on the production deployment schedule, and within 15 min or so all new pageloads should start respecting the new values. There is one remaining backport window today, from 4-5PM EST

Hi @Ejegg! Thanks so much. We don't want to change the donate values, at all; we don't want to make the move of showing banners again to donors, yet.

But we would like to open up fundraising banners to everyone who currently has a 'close' status, regardless of how long it's set to last for them currently.

Can we please implement that change this afternoon in time for hte deployment window?

Change #1215263 had a related patch set uploaded (by Ejegg; author: Ejegg):

[operations/mediawiki-config@master] Shorten 'close' cookie wait period for enwiki banners

https://gerrit.wikimedia.org/r/1215263

Change #1215263 merged by jenkins-bot:

[operations/mediawiki-config@master] Shorten 'close' cookie wait period for enwiki banners

https://gerrit.wikimedia.org/r/1215263

Mentioned in SAL (#wikimedia-operations) [2025-12-04T21:14:03Z] <jforrester@deploy2002> Started scap sync-world: Backport for [[gerrit:1215251|[tokwiki] Allow sysops to grant/remove confirmed status (T411683)]], [[gerrit:1214659|OATHAuth: Remove wmgOATHAuthDisableRight (T399664)]], [[gerrit:1214143|Remove /data-parsoid/ endpoint from specs per T393557 (T411517)]], [[gerrit:1215263|Shorten 'close' cookie wait period for enwiki banners (T411800)]]

Mentioned in SAL (#wikimedia-operations) [2025-12-04T21:18:17Z] <jforrester@deploy2002> mstyles, aaron, superpes, jforrester, ejegg: Backport for [[gerrit:1215251|[tokwiki] Allow sysops to grant/remove confirmed status (T411683)]], [[gerrit:1214659|OATHAuth: Remove wmgOATHAuthDisableRight (T399664)]], [[gerrit:1214143|Remove /data-parsoid/ endpoint from specs per T393557 (T411517)]], [[gerrit:1215263|Shorten 'close' cookie wait period for enwiki banners (T411800)]] synced to the t

Mentioned in SAL (#wikimedia-operations) [2025-12-04T21:24:07Z] <jforrester@deploy2002> Finished scap sync-world: Backport for [[gerrit:1215251|[tokwiki] Allow sysops to grant/remove confirmed status (T411683)]], [[gerrit:1214659|OATHAuth: Remove wmgOATHAuthDisableRight (T399664)]], [[gerrit:1214143|Remove /data-parsoid/ endpoint from specs per T393557 (T411517)]], [[gerrit:1215263|Shorten 'close' cookie wait period for enwiki banners (T411800)]] (duration: 10m 04s)

Now live on enwiki. Verified the setting shows up as expected in the console and that a browser which had previously been hiding banners due to a 3 day old close cookie is now showing them again.

Ejegg renamed this task from CentralNotice code changes to show a banner to a reader with the 'waitdate: close' status to CentralNotice config changes to show a banner to a reader with the 'waitdate: close' status.Dec 16 2025, 8:20 PM

@spatton, I'm going to revert this change on enwiki now that the end of year campaign is over.

Change #1226275 had a related patch set uploaded (by Ejegg; author: Ejegg):

[operations/mediawiki-config@master] Revert "Shorten 'close' cookie wait period for enwiki banners"

https://gerrit.wikimedia.org/r/1226275

Change #1226275 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Shorten 'close' cookie wait period for enwiki banners"

https://gerrit.wikimedia.org/r/1226275

Mentioned in SAL (#wikimedia-operations) [2026-01-14T21:24:26Z] <zabe@deploy2002> Started scap sync-world: Backport for [[gerrit:1226275|Revert "Shorten 'close' cookie wait period for enwiki banners" (T411800)]]

Mentioned in SAL (#wikimedia-operations) [2026-01-14T21:26:36Z] <zabe@deploy2002> zabe, ejegg: Backport for [[gerrit:1226275|Revert "Shorten 'close' cookie wait period for enwiki banners" (T411800)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-01-14T21:33:07Z] <zabe@deploy2002> Finished scap sync-world: Backport for [[gerrit:1226275|Revert "Shorten 'close' cookie wait period for enwiki banners" (T411800)]] (duration: 08m 40s)

OK, the temporary change has been reverted on production

Thanks for making this vital change in December, @Ejegg ; and for reverting the change now that the campaign is over.

Thanks for all your support!

Damilare set Final Story Points to 2.