Page MenuHomePhabricator
Create Task
Maniphest T411868

Fix iOS browsers scroll-to-top when collapsing a section
Closed, ResolvedPublic2 Estimated Story PointsFeature
Actions

Description

With useparsoid=0, collapsing a section results in being scrolled all the way to the top.
Looks Safari ends up reporting a 0 offset from those hidden content nodes.

Acceptance criteria:

  • Collapsing a section in old Parsoid output (useparsoid=0) scrolls accurately, putting the just-closed heading at the top

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix scroll-on-collapsemediawiki/extensions/ReaderExperimentswmf/1.46.0-wmf.5+10 -4
Fix scroll-on-collapsemediawiki/extensions/ReaderExperimentsmaster+10 -4
Fix scroll-to-top in iOS browsersmediawiki/extensions/ReaderExperimentsmaster+31 -35
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Dec 5 2025, 2:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2025, 2:17 PM
gerritbot added a comment.Dec 5 2025, 2:17 PM

Change #1215614 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Fix scroll-to-top in iOS browsers

https://gerrit.wikimedia.org/r/1215614

gerritbot added a project: Patch-For-Review.Dec 5 2025, 2:17 PM
matthiasmullie claimed this task.Dec 5 2025, 2:18 PM
matthiasmullie moved this task from Committed to Code Review on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.
gerritbot added a comment.Dec 8 2025, 7:59 PM

Change #1215614 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Fix scroll-to-top in iOS browsers

https://gerrit.wikimedia.org/r/1215614

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 8 2025, 8:00 PM
egardner moved this task from Code Review to QA on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.Dec 8 2025, 8:12 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 8 2025, 8:30 PM
gerritbot added a comment.Dec 9 2025, 11:53 AM

Change #1216776 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Fix scroll-on-collapse

https://gerrit.wikimedia.org/r/1216776

gerritbot added a project: Patch-For-Review.Dec 9 2025, 11:53 AM
matthiasmullie moved this task from QA to Code Review on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.Dec 9 2025, 12:01 PM
Etonkovidova mentioned this in T412123: [QA task] Regression testing - Sticky header.Dec 9 2025, 3:49 PM
egardner triaged this task as High priority.Dec 9 2025, 5:15 PM
matthiasmullie set the point value for this task to 2.Dec 9 2025, 5:16 PM
SherryYang-WMF moved this task from Sprint 5 (Nov 25 - Dec 9) Q2 25/26 to Sprint 6 (Dec 10 - EOY) Q2 25/26 on the Reader Growth Team board.Dec 9 2025, 5:50 PM
SherryYang-WMF edited projects, added Reader Growth Team (Sprint 6 (Dec 10 - EOY) Q2 25/26); removed Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26).
Aklapper added a project: ReaderExperiments.Dec 9 2025, 7:10 PM
gerritbot added a comment.Dec 9 2025, 7:13 PM

Change #1216776 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Fix scroll-on-collapse

https://gerrit.wikimedia.org/r/1216776

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2025, 7:31 PM
gerritbot added a comment.Dec 9 2025, 8:33 PM

Change #1216850 had a related patch set uploaded (by Kimberly Sarabia; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@wmf/1.46.0-wmf.5] Fix scroll-on-collapse

https://gerrit.wikimedia.org/r/1216850

gerritbot added a project: Patch-For-Review.Dec 9 2025, 8:33 PM
gerritbot added a comment.Dec 9 2025, 9:03 PM

Change #1216850 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.46.0-wmf.5] Fix scroll-on-collapse

https://gerrit.wikimedia.org/r/1216850

Stashbot mentioned this in T411869: Sticky header is not sticky on some articles.Dec 9 2025, 9:05 PM
Stashbot mentioned this in T412054: Content peaking through right-hand side of sticky header.
Stashbot mentioned this in T412146: Launch Mobile Expanded Sections on non-English wikis.

Mentioned in SAL (#wikimedia-operations) [2025-12-09T21:05:04Z] <egardner@deploy2002> Started scap sync-world: Backport for [[gerrit:1216848|Backport: Instrument sticky header session length to 1.46.0-wmf.5 (T412146)]], [[gerrit:1216850|Fix scroll-on-collapse (T411868 T411869)]], [[gerrit:1216851|Fix heading background positioning (T412054)]]

Stashbot added a comment.Dec 9 2025, 9:08 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-09T21:08:31Z] <egardner@deploy2002> egardner, ksarabia: Backport for [[gerrit:1216848|Backport: Instrument sticky header session length to 1.46.0-wmf.5 (T412146)]], [[gerrit:1216850|Fix scroll-on-collapse (T411868 T411869)]], [[gerrit:1216851|Fix heading background positioning (T412054)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Dec 9 2025, 9:13 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-09T21:13:29Z] <egardner@deploy2002> Finished scap sync-world: Backport for [[gerrit:1216848|Backport: Instrument sticky header session length to 1.46.0-wmf.5 (T412146)]], [[gerrit:1216850|Fix scroll-on-collapse (T411868 T411869)]], [[gerrit:1216851|Fix heading background positioning (T412054)]] (duration: 08m 26s)

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2025, 9:31 PM
matthiasmullie moved this task from Committed to QA on the Reader Growth Team (Sprint 6 (Dec 10 - EOY) Q2 25/26) board.Dec 10 2025, 9:51 AM
Etonkovidova updated the task description. (Show Details)Dec 11 2025, 4:47 PM
Etonkovidova moved this task from QA to Signoff on the Reader Growth Team (Sprint 6 (Dec 10 - EOY) Q2 25/26) board.
Etonkovidova subscribed.

Checked on enwiki wmf.5, iOS Safari with (and without) userparsoid=0 - the issue is fixed.

matthiasmullie closed this task as Resolved.Dec 11 2025, 5:15 PM
matthiasmullie added a project: ReaderExperiments-StickyHeaders.Jan 6 2026, 1:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits