Page MenuHomePhabricator
Create Task
Maniphest T411869

Sticky header is not sticky on some articles
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Pretty much what's in the title; happens on with useparsoid=0

Lengthy discussion with more details here: https://wikimedia.slack.com/archives/C08TB64J750/p1764863630432259

Acceptance criteria:

  • Headers are appropriately sticky in International_Space_Station?useskin=minerva&stickyHeaders=1&useparsoid=0
  • Headers are appropriately sticky in Bernoulli_number?useskin=minerva&stickyHeaders=1&useparsoid=0

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix scroll-on-collapsemediawiki/extensions/ReaderExperimentswmf/1.46.0-wmf.5+10 -4
Fix scroll-on-collapsemediawiki/extensions/ReaderExperimentsmaster+10 -4
Ensure scroll events are capturedmediawiki/extensions/ReaderExperimentsmaster+1 -1
Remove redundant fixmediawiki/extensions/ReaderExperimentsmaster+0 -8
Fix un-sticky headers when page overflows horizontallymediawiki/extensions/ReaderExperimentsmaster+6 -2
Fix unsticky sticky headersmediawiki/extensions/ReaderExperimentsmaster+10 -1
Customize query in gerrit

Related Objects

Event Timeline

matthiasmullie created this task.Dec 5 2025, 2:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2025, 2:23 PM
gerritbot added a comment.Dec 5 2025, 2:24 PM

Change #1215327 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Fix unsticky sticky headers

https://gerrit.wikimedia.org/r/1215327

gerritbot added a project: Patch-For-Review.Dec 5 2025, 2:24 PM
matthiasmullie claimed this task.Dec 5 2025, 2:24 PM
matthiasmullie moved this task from Committed to Code Review on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.
Etonkovidova subscribed.Dec 5 2025, 9:53 PM

There are quite few cases to check after the fix - did not see what may cause some article do not cooperate with the sticky headers.

Sticky headers work in this article - https://en.wikipedia.org/wiki/Euler%E2%80%93Maclaurin_formula

PatchDemoBot added a comment.Dec 6 2025, 12:55 AM

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://8ca74bcf7d.catalyst.wmcloud.org/w/

egardner updated the task description. (Show Details)Dec 6 2025, 1:33 AM
egardner subscribed.Dec 6 2025, 1:35 AM
In T411869#11437707, @Etonkovidova wrote:

There are quite few cases to check after the fix - did not see what may cause some article do not cooperate with the sticky headers.

Sticky headers work in this article - https://en.wikipedia.org/wiki/Euler%E2%80%93Maclaurin_formula

@Etonkovidova it looks like different kinds of article content are causing our feature to break in different ways.

@matthiasmullie's patch seems to fix the problem on the ISS article (which seems to be image related).

However, the patch does not fix whatever is happening on the Bernoulli number page. That issue seems to be caused by horizontal overflow on the page (caused by the presence of long mathematical formulae). So we may need another fix for that. In the meantime I will merge the first patch here.

egardner renamed this task from Sticky header is not sticky on International_Space_Station to Sticky header is not sticky on some articles.Dec 6 2025, 1:35 AM
gerritbot added a comment.Dec 6 2025, 1:42 AM

Change #1215327 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Fix unsticky sticky headers

https://gerrit.wikimedia.org/r/1215327

gerritbot added a comment.Dec 6 2025, 1:49 AM

Change #1215782 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/ReaderExperiments@master] [WIP] Fix un-sticky headers when page overflows horizontally

https://gerrit.wikimedia.org/r/1215782

PatchDemoBot added a comment.Dec 6 2025, 1:53 AM

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://9e8787bfd6.catalyst.wmcloud.org/w/

egardner added a comment.Dec 6 2025, 1:57 AM

See my WIP follow-up attempt for the Bernoulli number article here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ReaderExperiments/+/1215782; patchdemo here: https://9e8787bfd6.catalyst.wmcloud.org/wiki/Bernoulli_number?stickyHeaders=1

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 6 2025, 2:00 AM
gerritbot added a comment.Dec 8 2025, 7:38 PM

Change #1215782 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Fix un-sticky headers when page overflows horizontally

https://gerrit.wikimedia.org/r/1215782

gerritbot added a comment.Dec 8 2025, 8:02 PM

Change #1216637 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Remove redundant fix

https://gerrit.wikimedia.org/r/1216637

egardner updated the task description. (Show Details)Dec 8 2025, 8:11 PM
gerritbot added a comment.Dec 8 2025, 8:11 PM

Change #1216639 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Ensure scroll events are captured

https://gerrit.wikimedia.org/r/1216639

egardner moved this task from Code Review to QA on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.Dec 8 2025, 8:12 PM
PatchDemoBot added a comment.Dec 8 2025, 8:15 PM

Test wiki created on Patch demo by EGardner (WMF) using patch(es) linked to this task:
https://0dd37f3ca5.catalyst.wmcloud.org/w/

gerritbot added a comment.Dec 8 2025, 8:28 PM

Change #1216637 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Remove redundant fix

https://gerrit.wikimedia.org/r/1216637

gerritbot added a comment.Dec 8 2025, 8:28 PM

Change #1216639 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Ensure scroll events are captured

https://gerrit.wikimedia.org/r/1216639

Maintenance_bot removed a project: Patch-For-Review.Dec 8 2025, 8:30 PM
gerritbot added a comment.Dec 9 2025, 11:53 AM

Change #1216776 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@master] Fix scroll-on-collapse

https://gerrit.wikimedia.org/r/1216776

gerritbot added a project: Patch-For-Review.Dec 9 2025, 11:53 AM
matthiasmullie moved this task from QA to Code Review on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.Dec 9 2025, 12:01 PM
Etonkovidova mentioned this in T412123: [QA task] Regression testing - Sticky header.Dec 9 2025, 3:49 PM
egardner triaged this task as High priority.Dec 9 2025, 5:15 PM
matthiasmullie set the point value for this task to 5.Dec 9 2025, 5:16 PM
SherryYang-WMF moved this task from Sprint 5 (Nov 25 - Dec 9) Q2 25/26 to Sprint 6 (Dec 10 - EOY) Q2 25/26 on the Reader Growth Team board.Dec 9 2025, 5:50 PM
SherryYang-WMF edited projects, added Reader Growth Team (Sprint 6 (Dec 10 - EOY) Q2 25/26); removed Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26).
Aklapper added a project: ReaderExperiments.Dec 9 2025, 7:10 PM
gerritbot added a comment.Dec 9 2025, 7:13 PM

Change #1216776 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Fix scroll-on-collapse

https://gerrit.wikimedia.org/r/1216776

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2025, 7:31 PM
gerritbot added a comment.Dec 9 2025, 8:33 PM

Change #1216850 had a related patch set uploaded (by Kimberly Sarabia; author: Matthias Mullie):

[mediawiki/extensions/ReaderExperiments@wmf/1.46.0-wmf.5] Fix scroll-on-collapse

https://gerrit.wikimedia.org/r/1216850

gerritbot added a project: Patch-For-Review.Dec 9 2025, 8:33 PM
gerritbot added a comment.Dec 9 2025, 9:03 PM

Change #1216850 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@wmf/1.46.0-wmf.5] Fix scroll-on-collapse

https://gerrit.wikimedia.org/r/1216850

Stashbot added a comment.Dec 9 2025, 9:05 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-09T21:05:04Z] <egardner@deploy2002> Started scap sync-world: Backport for [[gerrit:1216848|Backport: Instrument sticky header session length to 1.46.0-wmf.5 (T412146)]], [[gerrit:1216850|Fix scroll-on-collapse (T411868 T411869)]], [[gerrit:1216851|Fix heading background positioning (T412054)]]

Stashbot mentioned this in T412054: Content peaking through right-hand side of sticky header.Dec 9 2025, 9:05 PM
Stashbot mentioned this in T412146: Launch Mobile Expanded Sections on non-English wikis.
Stashbot mentioned this in T411868: Fix iOS browsers scroll-to-top when collapsing a section.
Stashbot added a comment.Dec 9 2025, 9:08 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-09T21:08:31Z] <egardner@deploy2002> egardner, ksarabia: Backport for [[gerrit:1216848|Backport: Instrument sticky header session length to 1.46.0-wmf.5 (T412146)]], [[gerrit:1216850|Fix scroll-on-collapse (T411868 T411869)]], [[gerrit:1216851|Fix heading background positioning (T412054)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Dec 9 2025, 9:13 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-09T21:13:29Z] <egardner@deploy2002> Finished scap sync-world: Backport for [[gerrit:1216848|Backport: Instrument sticky header session length to 1.46.0-wmf.5 (T412146)]], [[gerrit:1216850|Fix scroll-on-collapse (T411868 T411869)]], [[gerrit:1216851|Fix heading background positioning (T412054)]] (duration: 08m 26s)

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2025, 9:31 PM
ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.5; 2025-12-02); removed MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 9 2025, 10:00 PM
matthiasmullie moved this task from Committed to QA on the Reader Growth Team (Sprint 6 (Dec 10 - EOY) Q2 25/26) board.Dec 10 2025, 9:51 AM
Etonkovidova moved this task from QA to Signoff on the Reader Growth Team (Sprint 6 (Dec 10 - EOY) Q2 25/26) board.Dec 11 2025, 4:43 PM

Checked on enwiki wmf.5 - the issue is fixed. The following articles with previously problematic stickyHeaders have been checked:

matthiasmullie closed this task as Resolved.Dec 11 2025, 5:15 PM
matthiasmullie added a project: ReaderExperiments-StickyHeaders.Jan 6 2026, 1:43 PM
PatchDemoBot added a comment.Mon, Jan 12, 2:20 AM

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://0dd37f3ca5.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Mon, Jan 12, 2:20 AM

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://8ca74bcf7d.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Mon, Jan 12, 2:20 AM

Test wiki on Patch demo by EGardner (WMF) using patch(es) linked to this task was deleted:

https://9e8787bfd6.catalyst.wmcloud.org/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits