When monthly convert is enabled, we render img tags with HideBanners URLs in the modal popup. That starts out hidden by CSS but as soon as the page loads I see the browser requesting HideBanners (and getting donate cookies). So anyone who has loaded a payments-wiki page will get a hide cookie with reason=donate, not just people who have actually completed a donation.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Monthly Convert: only set cookies when showing modal | mediawiki/extensions/DonationInterface | master | +37 -48 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change #1215714 had a related patch set uploaded (by Ejegg; author: Ejegg):
[mediawiki/extensions/DonationInterface@master] Monthly Convert: only set cookies when showing modal
Comment Actions
Change #1215714 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Monthly Convert: only set cookies when showing modal
Comment Actions
@spatton we've just deployed the patch to stop setting the "reason=donate" hide cookies as soon as donors load any monthly-convert-enabled payments form. Now it only sets them when the donation is complete and the monthly convert ask is triggered, as we initially intended.
Comment Actions
Thanks for catching this, and fixing it so promptly, @Ejegg. I can confirm that I see the change on my end too (not getting cookies added as soon as I visit Payments Wiki). Thank you!