Page MenuHomePhabricator

CommentStreams permalinks only work for head comments
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Make a comment on a page and also send a reply to it.
  • Open the page again using the URL from the permalink button on the reply.

What happens?:

Nothing happens.

What should have happened instead?:

When a link to a head comment is opened, the page scrolls down to the proper comment, so one would expect the same to happen for replies.

Software version:

MediaWiki: 1.44.2
CommentStreams: 8.0.3

Other information (browser name/version, screenshots, etc.):

Downstream task: https://issue-tracker.miraheze.org/T14332

Event Timeline

Change #1215874 had a related patch set uploaded (by SweetDonut0; author: SweetDonut0):

[mediawiki/extensions/CommentStreams@master] Add cs-target-comment class in createComment() instead

https://gerrit.wikimedia.org/r/1215874

Change #1217559 had a related patch set uploaded (by SomeRandomDeveloper; author: SweetDonut0):

[mediawiki/extensions/CommentStreams@REL1_45] Add cs-target-comment class in createComment() instead

https://gerrit.wikimedia.org/r/1217559

Change #1217560 had a related patch set uploaded (by SomeRandomDeveloper; author: SweetDonut0):

[mediawiki/extensions/CommentStreams@REL1_44] Add cs-target-comment class in createComment() instead

https://gerrit.wikimedia.org/r/1217560

Change #1217561 had a related patch set uploaded (by SomeRandomDeveloper; author: SweetDonut0):

[mediawiki/extensions/CommentStreams@REL1_43] Add cs-target-comment class in createComment() instead

https://gerrit.wikimedia.org/r/1217561

Change #1217561 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_43] Add cs-target-comment class in createComment() instead

https://gerrit.wikimedia.org/r/1217561

Change #1217560 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_44] Add cs-target-comment class in createComment() instead

https://gerrit.wikimedia.org/r/1217560

Change #1217559 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@REL1_45] Add cs-target-comment class in createComment() instead

https://gerrit.wikimedia.org/r/1217559

Change #1215874 merged by jenkins-bot:

[mediawiki/extensions/CommentStreams@master] Add cs-target-comment class in createComment() instead

https://gerrit.wikimedia.org/r/1215874