In languages/i18n/en.json, the linksearch-text-ignored-domains' key begins with: Links to the following {{PLURAL:$2|domain is|domains are}} not recorded.
For $2==1, this yields: Links to the following domain is not recorded, etc.
This is grammatically incorrect. The verb refers to "links", not "domain(s)", so should always be "are" and never "is".
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Correct grammar in linksearch ignored domains text | mediawiki/core | master | +1 -1 |
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3
Change #1216186 had a related patch set uploaded (by Trevorhauter; author: Trevorhauter):
[mediawiki/core@master] Correct grammar in linksearch ignored domains text
Change #1216186 merged by jenkins-bot:
[mediawiki/core@master] Correct grammar in linksearch ignored domains text
Welcome to the Wikimedia technical community and congrats on your first merged patch!