Change #1217264 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PersonalDashboard@master] WIP: use Codex icons instead of OOUI icons

https://gerrit.wikimedia.org/r/1217264

Okay, I've done some of the underlying structural cleanup.

Change #1217264 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Module header/footer server side cleanup

https://gerrit.wikimedia.org/r/1217264

Change #1218787 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] bugfix mobile module card design

https://gerrit.wikimedia.org/r/1218787

Test wiki created on Patch demo by KGraessle-WMF using patch(es) linked to this task:
https://2db0445b81.catalyst.wmcloud.org/w/

@OTichonova

Hi, I implemented the design fixes outlined in the ticket and this is ready for a design review.
There's one outstanding implementation:

The padding around the title is too large. Header height is 46pts

Can you send me a screenshot that demos where the extra padding is?

Test wiki on Patch demo by KGraessle-WMF using patch(es) linked to this task was deleted:

https://2db0445b81.catalyst.wmcloud.org/w/

Hi @Kgraessle, I was referring to the height of the header/element (Figma)

Figma & screenshot

Latest patch demo here.

Hi @Kgraessle, great work so far! Just a few nits:

• On desktop, the "Review changes" header is vertically off-center from the rest of the module headers:
  
• On mobile, the navbar title is horizontally off-center from the rest of the page: {F71149763}
• On mobile, the navbar doesn't stick when scrolling down like Special:Preferences does:
  

The last one can easily be fixed by just adding position: sticky; top: 0; to .personal-dashboard-module-header.

Hi @Kgraessle, this looks great! 2 small things

1. The arrow in the header seems smaller. Right now it fits in a 14x14pts frame, while in the designs it is a little bit bigger, fitting in a 20x20pts frame.
2. Can the margin by the arrow and info icon be 12 pts?

Patchdemo	Design

@Dillon

On desktop, the "Review changes" header is vertically off-center from the rest of the module headers

Done!

On mobile, the navbar title is horizontally off-center from the rest of the page: {F71149763}

Done! (unless I'm missing something as the screenshot isn't appearing).

On mobile, the navbar doesn't stick when scrolling down like Special:Preferences does:

@OTichonova
Do we want the navbar to be sticky?

The arrow in the header seems smaller. Right now it fits in a 14x14pts frame, while in the designs it is a little bit bigger, fitting in a 20x20pts frame.

@OTichonova
Can you tell me what browser you're using for reproducing this?
I'm seeing the arrow as 16x16 on patch demo:

Can the margin by the arrow and info icon be 12 pts?

Done!

@Kgraessle
I am in Google Chrome Version 143.0.7499.147

I just saw another thing:
The title size (the "Review changes") is a Header 4 size (font 16, line-height 26) in the designs, while it is bigger in the patchdemo.

Change #1218787 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] bugfix mobile module card design

https://gerrit.wikimedia.org/r/1218787

SPA-like URL navigation (e.g. Special:PersonalDashboard to Special:PersonalDashboard/RiskyArticleEdits and vice versa)

Let's make this another ticket. It's a nice-to-have, but for the MVP the functionality is the same.

In T412053#11496547, @Samwalton9-WMF wrote:

SPA-like URL navigation (e.g. Special:PersonalDashboard to Special:PersonalDashboard/RiskyArticleEdits and vice versa)

Let's make this another ticket. It's a nice-to-have, but for the MVP the functionality is the same.

T414578: Don't reload Special:Dashboard when selecting a module in mobile view