Refactor Myne application and references name to WikisourceReader. Since the app UI is forked from Myne, there are still some leftover references to it.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | LGoto | T403210 Projects and mentors for Wikimedia Outreachy Round 31 | |||
| Resolved | Muguro | T405593 Outreachy 31: Improve the Wikisource Reader App | |||
| Resolved | Muguro | T412114 Refactor "Myne" application to "WikisourceReader" |
Event Timeline
Comment Actions
Hi @Saiphani02,
I have oped a PR for this issue, https://github.com/cis-india/Wikisource-Reader/pull/61
please check.
Comment Actions
Some things I noticed:
- The package name is org.cis_india.wsreader so please dont use com.starry.wsreader
- Ignore mentions of Myne in strings.xml files since they are translations and will be handled by the community via translate wiki.
- Will this be a breaking change? Do you think this will have any effects on users local databases when updating the app?
Comment Actions
This is well noted, I will revert as mentioned and research more on the database schemas.
Comment Actions
@Saiphani02 I have updated the PR, used com.starry.wikisourcesreader instead and reverted the transtlations back to Myne. I have also tested this and its not breaking local database for the users. Kindly check
Comment Actions
@Muguro As I've mentioned in my earlier comment, the package name is org.cis_india.wsreader so please do not use com.starry.wikisourcesreader.
Comment Actions
@Saiphani02 I have updated the package as mentioned. would really appreciate some guidance how the schemas are used?
Comment Actions
@Muguro Thank you, merged. I'm no expert but in general these are various versions (1 to 5) of the db schema tracking all the migrations?