Page MenuHomePhabricator
Create Task
Maniphest T412117

Cursor position is out of sync in DiscussionTools with CodeMirror
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Bhsd
Authored By
Ponor
Dec 9 2025, 2:12 PM
Tags
Referenced Files
F70965244: az_recorder_20251209_130621_edited.mp4
Dec 9 2025, 6:11 PM
F70964590: Screenshot_2025-12-09-18-29-45-077_com.opera.browser.jpg
Dec 9 2025, 5:30 PM
F70964510: Screenshot_2025-12-09-18-23-22-057_com.opera.browser.jpg
Dec 9 2025, 5:27 PM
F70964503: Screenshot_2025-12-09-18-22-11-641_com.opera.browser.jpg
Dec 9 2025, 5:27 PM
F70964494: Screenshot_2025-12-09-18-21-10-195_com.opera.browser.jpg
Dec 9 2025, 5:27 PM
F70961664: az_recorder_20251209_084103_edited~2.mp4
Dec 9 2025, 2:12 PM
Subscribers
Aklapper
Bhsd
Escargot_rouge
• MusikAnimal
Ponor
Prakhar0804
Samwilson
TheresNoTime

Description

Steps to replicate the issue (include links if applicable):

  • Use Reply in a discussion with CodeMirror beta feature enabled on mobile

What happens?:

  • Every time spacebar is pressed, the cursor advances one additional space past the text. When the cursor is put back anywhere within the typed text, new edits do not happen where the cursor is shown. See attached screen recording.

Other information (browser name/version, screenshots, etc.):
Firefox for Android and Chrome for Android with advanced syntax highlighting turned on.

Gboard virtual keyboard on Pixel 10

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix cursor position sync in DiscussionTools mobile overlay (T412117)mediawiki/extensions/CodeMirrormaster+140 -17
Explicitly set font size in VisualEditor with CodeMirror 6 enabledmediawiki/skins/MinervaNeuemaster+1 -0
Customize query in gerrit

Event Timeline

Ponor created this task.Dec 9 2025, 2:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2025, 2:12 PM
Escargot_rouge subscribed.EditedDec 9 2025, 2:14 PM

I have the same issue. This happens with every character and not only space.

Bhsd subscribed.Dec 9 2025, 4:01 PM
In T412117#11444050, @Escargot_rouge wrote:

I have the same issue. This happens with every character and not only space.

Are you also using Android? I cannot reproduce it on iOS.

Escargot_rouge added a comment.Dec 9 2025, 4:23 PM
In T412117#11444353, @Bhsd wrote:
In T412117#11444050, @Escargot_rouge wrote:

I have the same issue. This happens with every character and not only space.

Are you also using Android? I cannot reproduce it on iOS.

Yes Android

Escargot_rouge added a comment.EditedDec 9 2025, 5:27 PM

I tested more, and the issue is related to font size. The problem doesn't actually lie with the cursor, which is correctly displayed considering the expected text size, but with the text size which is always small in the form. It only occurs with medium and big font size.

  • Big font size with beta feature enabled:

Screenshot_2025-12-09-18-21-10-195_com.opera.browser.jpg (2×1 px, 386 KB)

  • Small font size with beta feature enabled:

Screenshot_2025-12-09-18-22-11-641_com.opera.browser.jpg (2×1 px, 409 KB)

  • Big font size with beta feature disbled:

Screenshot_2025-12-09-18-29-45-077_com.opera.browser.jpg (2×1 px, 392 KB)

Escargot_rouge attached a referenced file: F70964590: Screenshot_2025-12-09-18-29-45-077_com.opera.browser.jpg. (Show Details)Dec 9 2025, 5:33 PM
Ponor added a comment.Dec 9 2025, 6:11 PM

Yeah, it has to do with the font size choice. The cursor shift is most pronounced when a space is typed in.
In Chrome, when the first word is followed by a space, the word is shown in two sizes. That can be undone by typing in a backspace.

Bhsd added a project: VisualEditor-MediaWiki-2017WikitextEditor.Dec 10 2025, 12:54 AM

There is a conflict between MobileFrontend and MinervaNeue styles in VisualEditor-MediaWiki-2017WikitextEditor. .mf-font-size-clientpref-regular .content p from MobileFrontend enlarges the font size of the hidden VE surface, while .cm-editor .cm-scroller from MinvervaNeue specifies the font size of the CM6 content.

Bhsd added projects: MinervaNeue, MobileFrontend.Dec 10 2025, 12:57 AM
Bhsd moved this task from Backlog to Bugs on the MediaWiki-extensions-CodeMirror board.Dec 10 2025, 1:06 AM
gerritbot added a comment.Dec 10 2025, 1:13 AM

Change #1216878 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/skins/MinervaNeue@master] Explicitly set font size in VisualEditor with CodeMirror 6 enabled

https://gerrit.wikimedia.org/r/1216878

gerritbot added a project: Patch-For-Review.Dec 10 2025, 1:13 AM
Maintenance_bot added a project: VisualEditor.Dec 10 2025, 1:29 AM
Jdlrobson-WMF moved this task from Untriaged to Tracking on the MobileFrontend board.Dec 10 2025, 5:48 PM
Jdlrobson-WMF edited projects, added MobileFrontend (Tracking); removed MobileFrontend.
Prakhar0804 claimed this task.Dec 11 2025, 11:07 AM
gerritbot added a comment.Dec 11 2025, 11:44 AM

Change #1217489 had a related patch set uploaded (by Prakhar0804; author: Prakhar0804):

[mediawiki/extensions/CodeMirror@master] Fix cursor position sync in DiscussionTools mobile overlay (T412117)

https://gerrit.wikimedia.org/r/1217489

Bhsd added subscribers: • MusikAnimal, TheresNoTime, Samwilson.Dec 11 2025, 12:51 PM
gerritbot added a comment.Dec 16 2025, 12:36 AM

Change #1216878 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Explicitly set font size in VisualEditor with CodeMirror 6 enabled

https://gerrit.wikimedia.org/r/1216878

• MusikAnimal changed the task status from Open to In Progress.Dec 16 2025, 12:50 AM

Should go live with this week's train.

Bhsd claimed this task.Dec 17 2025, 11:47 AM
Bhsd added a subscriber: Prakhar0804.
• MusikAnimal closed this task as Resolved.Tue, Dec 23, 4:56 PM
• MusikAnimal moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.Tue, Dec 23, 6:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits