Page MenuHomePhabricator
Create Task
Maniphest T412140

[MEX][Score] support musical notation datatype for editing
Closed, ResolvedPublic
Actions

Description

In order to for MEX to support musical notation, a ValueStrategy must be registered for the datatype. Since the "musical-notation" datatype is added and defined by Extension:Score, this support should be added in that extension's repo, and not in Wikibase directly.

An example of registering strategies in another extension can be found here: Add support for Lexemes in wbui2025

Acceptance criteria

  • the value strategy is registered with the snakValueStrategyFactory when wbui2025 is enabled
  • 'musical-notation' is removed from WBUI2025_UNSUPPORTED_DATATYPES (in Wikibase)
  • it is possible to add and edit statements with musical notation datatype
  • there is a test (in Score) that confirms the happy-path of adding and editing a statement

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove 'musical-notation' from WBUI2025_UNSUPPORTED_DATATYPESmediawiki/extensions/Wikibasemaster+0 -1
Add cypress tests to Score extensionmediawiki/extensions/Scoremaster+3 K -5
Add wbui2025 support for Score valuesmediawiki/extensions/Scoremaster+9 K -227
Export StringValueStrategy so it can be subclassedmediawiki/extensions/Wikibasemaster+2 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

AudreyPenven_WMDE created this task.Dec 9 2025, 5:19 PM
AudreyPenven_WMDE mentioned this in T407247: [MEX][SPIKE] M4.1.10 - Musical notation statements on mobile.Dec 9 2025, 5:46 PM
AudreyPenven_WMDE added a project: Wikidata-Omega.Dec 9 2025, 5:52 PM
AudreyPenven_WMDE moved this task from Incoming to Ready for Task Time (Story Writing) on the Wikidata-Omega board.
AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Dec 9 2025, 5:54 PM
karapayneWMDE updated the task description. (Show Details)Dec 16 2025, 10:24 AM
karapayneWMDE moved this task from Ready for Task Time (Story Writing) to The Backlog on the Wikidata-Omega board.Dec 16 2025, 10:26 AM
ArthurTaylor claimed this task.Jan 5 2026, 10:00 AM
ArthurTaylor moved this task from The Backlog to The Board on the Wikidata-Omega board.
ArthurTaylor edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.
ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Jan 6 2026, 8:30 AM

Change #1223627 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Score@master] Add wbui2025 support for Score values

https://gerrit.wikimedia.org/r/1223627

gerritbot added a project: Patch-For-Review.Jan 6 2026, 8:30 AM
gerritbot added a comment.Jan 6 2026, 10:54 AM

Change #1223638 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Export StringValueStrategy so it can be subclassed

https://gerrit.wikimedia.org/r/1223638

gerritbot added a comment.Jan 7 2026, 10:02 AM

Change #1224025 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Remove 'musical-notation' from WBUI2025_UNSUPPORTED_DATATYPES

https://gerrit.wikimedia.org/r/1224025

gerritbot added a comment.Jan 7 2026, 11:20 AM

Change #1224050 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Score@master] [WIP] Add cypress tests to Score extension

https://gerrit.wikimedia.org/r/1224050

ArthurTaylor added a comment.Jan 7 2026, 1:17 PM

The attached changes enable the datatype. There is some limited unit-testing - the code introduced is not very complicated or dangerous, and I haven't gone to the trouble of retroactively adding tests for existing Score functionality.

I've also added end-to-end tests with Cypress. Because there is no shellbox-score container and lilypond is not installed in the CI docker images, actually rendering scores will not currently work, but we can test that the end-to-end integration is somewhat functional.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Jan 7 2026, 1:17 PM
ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.
ArthurTaylor subscribed.
gerritbot added a comment.Jan 7 2026, 2:48 PM

Change #1223638 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Export StringValueStrategy so it can be subclassed

https://gerrit.wikimedia.org/r/1223638

ArthurTaylor assigned this task to Lucas_Werkmeister_WMDE.Jan 8 2026, 8:05 AM
ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.
gerritbot added a comment.Jan 12 2026, 5:13 PM

Change #1223627 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Add wbui2025 support for Score values

https://gerrit.wikimedia.org/r/1223627

gerritbot added a comment.Jan 12 2026, 5:16 PM

Change #1224025 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove 'musical-notation' from WBUI2025_UNSUPPORTED_DATATYPES

https://gerrit.wikimedia.org/r/1224025

gerritbot added a comment.Jan 12 2026, 5:16 PM

Change #1224050 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Add cypress tests to Score extension

https://gerrit.wikimedia.org/r/1224050

Maintenance_bot removed a project: Patch-For-Review.Jan 12 2026, 5:31 PM
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Jan 13 2026, 9:51 AM
Lucas_Werkmeister_WMDE moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.
Arian_Bozorg closed this task as Resolved.Jan 15 2026, 6:40 PM
Arian_Bozorg claimed this task.
Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.
Arian_Bozorg subscribed.

Thanks so much, looks good!

karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).Tue, Feb 10, 5:09 PM
karapayneWMDE moved this task from Newly completed tasks to 2026 Q1 on the Wikidata-Omega (Completed Tasks) board.Tue, Feb 10, 5:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits