[MEX][Score] Display Lilypond errors for statement values
Closed, ResolvedPublic
Actions

Assigned To

mahmoud.abdelsattar.wmde

Authored By

	AudreyPenven_WMDE
	Dec 9 2025, 5:43 PM

Project Tags

Referenced Files

	F81207788: image.png
	May 13 2026, 11:34 AM

	F72438107: image.png
	Feb 26 2026, 3:53 PM

	F71482009: image.png
	Jan 9 2026, 4:15 PM

	F70964692: image.png
	Dec 9 2025, 5:43 PM

Subscribers

View All 10 Subscribers

Description

Errors for musical notation (Lilypond notation) are shown only after saving, due to technical limitations of how the extension works.

When there is an error, display a message instead of the snak value and show the full Lilypond error in a tooltip.
note: Tooltips will be introduced in the work for WikibaseQualityConstraints, in T411608

Figma file

Acceptance Criteria

Notice of the Lilypond compilation error is shown in place of the snak value, matching the design in Figma
The full lilypond error is shown in a tooltip after tapping on the error icon, matching the design in Figma
In case the music notation has an error, a generic error message should be showing "Unable to display the value".
In the popover, the error message should be displayed as a full message (it would be nice to not have the red background in the error).
The popover is triggered on click.
Option 4 should be implemented (the html parsing is not considered).

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Add custom error popover formatter	Hasan Akgün (WMDE)	mediawiki/extensions/Score	master	+645 -39
Add error popover formatter support	Hasan Akgün (WMDE)	mediawiki/extensions/Wikibase	master	+78 -35
Add options override option to indicator popover	Hasan Akgün (WMDE)	mediawiki/extensions/Wikibase	master	+258 -21
Add options override option to indicator popover	Hasan Akgün (WMDE)	mediawiki/extensions/Score	master	+38 -4
Update Cypress test for Wikibase change	Lucas Werkmeister (WMDE)	mediawiki/extensions/Score	master	+23 -4
POC: Make popover contents a list of refs of lists	Lucas Werkmeister (WMDE)	mediawiki/extensions/Wikibase	master	+21 -21
WIP: Display LilyPond errors in popover	Lucas Werkmeister (WMDE)	mediawiki/extensions/Wikibase	master	+51 -4
Display LilyPond errors in popover	Lucas Werkmeister (WMDE)	mediawiki/extensions/Wikibase	master	+191 -19
Bump wmde/php-vuejs-templating to 2.2.0-beta.9	Lucas Werkmeister (WMDE)	mediawiki/vendor	master	+68 -26

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T394621 [MEX] Mobile Editing Experience of Items Project
Resolved	karapayneWMDE	T407324 [MEX] M4 - Create editing functionality for the remaining datatypes for statements on Items on mobile
Resolved	karapayneWMDE	T410855 [MEX] M4.1 First Pass + Functionalty
Resolved	Arian_Bozorg	T407247 [MEX][SPIKE] M4.1.10 - Musical notation statements on mobile
Resolved	mahmoud.abdelsattar.wmde	T412145 [MEX][Score] Display Lilypond errors for statement values

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1228436 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/vendor@master] Bump wmde/php-vuejs-templating to 2.2.0-beta.9

https://gerrit.wikimedia.org/r/1228436

Change #1228436 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wmde/php-vuejs-templating to 2.2.0-beta.9

https://gerrit.wikimedia.org/r/1228436

Change #1230966 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] POC: Make popover contents a list of refs of lists

https://gerrit.wikimedia.org/r/1230966

Change #1234337 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Display LilyPond errors in popover

https://gerrit.wikimedia.org/r/1234337

I think Display LilyPond errors in popover is ready for review; the other changes can be abandoned later.

hoo claimed this task.Feb 2 2026, 10:02 AM

hoo moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

I didn't test this with actual Lilypond errors, but manually changed my set up to emit the error-html.

Change #1234337 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Display LilyPond errors in popover

https://gerrit.wikimedia.org/r/1234337

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.15; 2026-02-10).Feb 5 2026, 9:00 PM

Change #1224980 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] WIP: Display LilyPond errors in popover

Reason:

superseded by Ibd71713995

https://gerrit.wikimedia.org/r/1224980

Change #1230966 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] POC: Make popover contents a list of refs of lists

Reason:

superseded by Ibd71713995 (I think sooner or later a reactive version of the constraint indicators would still be useful, but we can figure that out later)

https://gerrit.wikimedia.org/r/1230966

Maintenance_bot removed a project: Patch-For-Review.Feb 6 2026, 11:31 AM

Lucas_Werkmeister_WMDE mentioned this in T418069: Cypress test wbui2025/editAndAddScoreStatement.cy.ts in Score is broken.Feb 23 2026, 1:12 PM

Change #1242357 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Score@master] Update Cypress test for Wikibase change

https://gerrit.wikimedia.org/r/1242357

gerritbot added a project: Patch-For-Review.Feb 23 2026, 1:22 PM

Change #1242357 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Update Cypress test for Wikibase change

https://gerrit.wikimedia.org/r/1242357

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2026, 4:32 PM

mahmoud.abdelsattar.wmde moved this task from Ready for Tech Verification to In Tech Verification on the Wikidata-Omega (The Board) board.Feb 24 2026, 8:57 AM

Some issues were found during the inspection (mostly related to UX):

The popover doesn't have a heading text (well, it has, it but doesn't show up) .. tested locally and test wikidata.
~~The popover error block should not have the error icon, it should be placed in the header to match the task Figma designs (low priority).~~
The width of the popover shows incorrect alignment (discussed on the task T417645) and might fall in the other task's scope.

Screenshot:

Will move it back to "Ready for development"

Yes, we’re just showing the whole error block from the Score extension without “dissecting” it in any way. I think we discussed this in some story time meeting and agreed that it was okay? But I’m not sure… maybe something to discuss when Alice comes back.

@Lucas_Werkmeister_WMDE Yes, you are right .. I remember it (I thought it was only in my head since it was not mentioned in the description), I've edited my comment to discard this one.

My comment also applies to the first bullet point – the “intended” heading text, “Unable to compile LilyPond file”, is also part of the error block from the Score extension. I don’t think we should just duplicate it.

I thought the heading text should be "Issues", and the sub-heading "Unable to compile LilyPond input file:" could be part of the error message.
That's from the screenshots provided in the task, not sure if is it outdated or valid.

I think the Figma design and screenshots are generally outdated following our decision to display the Score error as a full block – I’d prefer to hear from Alice first if this is okay or not before adding a title.

HasanAkgun_WMDE moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.Mar 6 2026, 9:03 AM

HasanAkgun_WMDE claimed this task.Mar 9 2026, 9:23 AM

Some issues were found during the inspection (mostly related to UX):
The popover doesn't have a heading text (well, it has, it but doesn't show up) .. tested locally and test wikidata.
The popover error block should not have the error icon, it should be placed in the header to match the task Figma designs (low priority).
The width of the popover shows incorrect alignment (discussed on the task T417645) and might fall in the other task's scope.

Dear @Alice.moutinho , Could you please verify the previous mentioned issues from the comments from the UX perspective?
Thank you!

ArthurTaylor removed HasanAkgun_WMDE as the assignee of this task.Mar 16 2026, 8:45 AM

ArthurTaylor moved this task from In Development to Ready for Development on the Wikidata-Omega (The Board) board.

ArthurTaylor added a subscriber: HasanAkgun_WMDE.

Review: There are two open questions:

The popover doesn't have a heading text (well, it has, it but doesn't show up) .. tested locally and test wikidata.

Should there be a header in addition to the Lilypond error block ? Or are we okay with only displaying the error block?

The width of the popover shows incorrect alignment (discussed on the task T417645) and might fall in the other task's scope.

Did T417645 resolve the alignment issue ?

Ideally it would be good to have something closer to the design, so that the only box contained in the modal is the message with the lilypond error; with the icon and header outside and above like it is in the design.

If this is not possible, whoever picks this up can have a quick call with Alice to work through the possibilities.

If there is no clear solution after discussing with Alice, we can move this to M5 as it's currently functional (although not ideal) and shouldn't be blocking us from M4

ArthurTaylor assigned this task to HasanAkgun_WMDE.Apr 1 2026, 9:09 AM

ArthurTaylor moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.

Change #1268593 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/extensions/Wikibase@master] Add options override option to indicator popover

https://gerrit.wikimedia.org/r/1268593

gerritbot added a project: Patch-For-Review.Apr 7 2026, 4:19 PM

Change #1268595 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/extensions/Score@master] Add options override option to indicator popover

https://gerrit.wikimedia.org/r/1268595

I've tried to address both concerns by adding custom options/overrides to popover indicator, therefore it can be used by other extensions.

HasanAkgun_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.Apr 7 2026, 4:48 PM

Lucas_Werkmeister_WMDE claimed this task.Apr 8 2026, 1:37 PM

Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

(Reassigning back to Hasan as I don’t think I have anything to add at the moment beyond my review comments from 9 April.)

HasanAkgun_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.May 4 2026, 8:22 AM

HasanAkgun_WMDE removed HasanAkgun_WMDE as the assignee of this task.May 7 2026, 9:24 AM

mahmoud.abdelsattar.wmde claimed this task.May 12 2026, 11:21 AM

mahmoud.abdelsattar.wmde moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

Peer review findings:
1- The popover header doesn't have the icon, but the icon is placed inside the Lilypond errors block (there is an icon but not visible).
2- The width of the popover still shows incorrect alignment.

Screenshot:

HasanAkgun_WMDE claimed this task.May 18 2026, 8:13 AM

HasanAkgun_WMDE moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.

Change #1268595 abandoned by Hasan Akgün (WMDE):

[mediawiki/extensions/Score@master] Add options override option to indicator popover

Reason:

Change of approach

https://gerrit.wikimedia.org/r/1268595

Change #1268593 abandoned by Hasan Akgün (WMDE):

[mediawiki/extensions/Wikibase@master] Add options override option to indicator popover

Reason:

Change of approach

https://gerrit.wikimedia.org/r/1268593

Maintenance_bot removed a project: Patch-For-Review.May 19 2026, 8:30 PM

HasanAkgun_WMDE removed HasanAkgun_WMDE as the assignee of this task.May 19 2026, 8:57 PM

HasanAkgun_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

HasanAkgun_WMDE updated Other Assignee, added: HasanAkgun_WMDE.

Hi @HasanAkgun_WMDE is there a new patch for the solution we should look into?
I'm not able to find it and the old patches are abandoned.

Change #1289411 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/extensions/Score@master] Add custom error popover formatter

https://gerrit.wikimedia.org/r/1289411

Change #1289410 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/extensions/Wikibase@master] Add error popover formatter support

https://gerrit.wikimedia.org/r/1289410

In T412145#11939349, @mahmoud.abdelsattar.wmde wrote:

Hi @HasanAkgun_WMDE is there a new patch for the solution we should look into?
I'm not able to find it and the old patches are abandoned.

Sorry @mahmoud.abdelsattar.wmde , I wasn't aware but it's fixed now. There are some recommended changes and investigation, I will add handover notes soon.

Handover Notes

What is this ticket about (tl;dr style)?
We're trying to find a way to fix how Lilypond errors seem on new MEX UI.

Where did you leave off?
I've abandoned previous patches and created 2 new ones.

On Wikibase side, the patch itself makes it possible to register a custom error popover formatter, so any extension can use it to format what it puts inside the popover content and title areas.
On Score side, the patch uses this new extension method.

What were your intended next steps?
During mob review with @ArthurTaylor and @Lucas_Werkmeister_WMDE , since I've hardcoded error HTML inside scoreValueStrategy.spec.js , if the populated codex code changes that test could fail and block CI.

So, this is the next thing to address. Other than that there's a concern about efficiency of Wikibase patch, but it's not a priority and probably can be deferred.

Lucas_Werkmeister_WMDE claimed this task.May 22 2026, 2:28 PM

Lucas_Werkmeister_WMDE moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.

In T412145#11940511, @HasanAkgun_WMDE wrote:

During mob review with @ArthurTaylor and @Lucas_Werkmeister_WMDE , since I've hardcoded error HTML inside scoreValueStrategy.spec.js , if the populated codex code changes that test could fail and block CI.

Done in PS5 of the Score change.

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.May 26 2026, 2:27 PM

Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

AudreyPenven_WMDE claimed this task.May 26 2026, 2:49 PM

AudreyPenven_WMDE moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/1289411 is the most recent patch, from Lucas, which once reviewed should complete the entire ticket

Change #1289410 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add error popover formatter support

https://gerrit.wikimedia.org/r/1289410

Change #1289411 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Add custom error popover formatter

https://gerrit.wikimedia.org/r/1289411