Page MenuHomePhabricator

Replace slug with name in the /api/v1/instrument response to be aligned with /api/v1/experiments
Closed, ResolvedPublic1 Estimated Story Points

Description

Description

At this time the response for /api/v1/experiments is including the name of the experiment as a property called named but the equivalent property for an instrument's name is called slug in the response for /api/v1/instruments. We want to align this and use name for both cases.

There is already a change in Test Kitchen UI to modify the response for /api/v1/instruments to include the name of the instrument as slug and name (both properties). At the time of writing this It was merged and it's pending deployment. Once we deploy that change, we will be able to make the corresponding change in MetricsPlatform/TestKitchen to read only name. And once we do that, we will update again Test Kitchen UI to include only name as the property to mean the instrument name

Acceptance criteria

  • TestKitchen extension just reads config['name']. Considering config['slug'] is not needed anymore here (be sure that this change has been deployed already, the Test Kitchen UI change mentioned above)
  • Update Test Kitchen UI to include only the name property in the response for /api/v1/instruments. The workaround consisted of keeping both fields in that response, name and slug while working on updating TestKitchen extension

Event Timeline

Sfaci set the point value for this task to 1.
Sfaci moved this task from Incoming to Backlog on the Test Kitchen board.

Change #1219941 had a related patch set uploaded (by Kareid; author: Kareid):

[mediawiki/extensions/MetricsPlatform@master] Remove checking of slug field

https://gerrit.wikimedia.org/r/1219941

Change #1219941 merged by jenkins-bot:

[mediawiki/extensions/MetricsPlatform@master] Remove checking of slug field

https://gerrit.wikimedia.org/r/1219941

Sfaci updated the task description. (Show Details)

Change #1224778 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/MetricsPlatform@master] devserver: Use upstream image for xlab service directly

https://gerrit.wikimedia.org/r/1224778

Change #1224786 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/TestKitchen@master] devserver: Use upstream image for xlab service directly

https://gerrit.wikimedia.org/r/1224786

Change #1224778 merged by jenkins-bot:

[mediawiki/extensions/MetricsPlatform@master] devserver: Use upstream image for xlab service directly

https://gerrit.wikimedia.org/r/1224778

Change #1224786 merged by jenkins-bot:

[mediawiki/extensions/TestKitchen@master] devserver: Use upstream image for xlab service directly

https://gerrit.wikimedia.org/r/1224786

The MediaWiki change was deployed yesterday in production so only the Test Kitchen UI one is pending to deploy here. We will do during the next Test Kitchen UI deployment window (next Tuesday)

Change #1226276 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Test Kitchen UI: Deploying v1.1.5 release to staging

https://gerrit.wikimedia.org/r/1226276

Change #1226276 merged by jenkins-bot:

[operations/deployment-charts@master] Test Kitchen UI: Deploying v1.1.5 release to staging

https://gerrit.wikimedia.org/r/1226276

Change #1226281 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Test Kitchen UI: Deploying v1.1.5 release to staging

https://gerrit.wikimedia.org/r/1226281

Change #1226281 merged by jenkins-bot:

[operations/deployment-charts@master] Test Kitchen UI: Deploying v1.1.5 release to production

https://gerrit.wikimedia.org/r/1226281