JSON uses non-standard Codex design tokens
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson-WMF
	Dec 10 2025, 1:03 AM

Description

Steps to replicate the issue (include links if applicable):

Visit https://it.wikivoyage.org/wiki/MediaWiki:Gadget-ListingEditor.json

Screenshot 2025-12-09 at 4.56.45 PM.png (801×1 px, 189 KB)

Switch to dark mode

Screenshot 2025-12-09 at 4.57.01 PM.png (712×1 px, 88 KB)

What happens?:

The use of green seems inappropriate here but might be a good example of expanding Codex's design tokens for presentation needs.
The color in dark mode does not correspond with the one in light mode
This requires additional and unnecessary CSS for dark mode support that we'd like to clean up.

What should have happened instead?:
There seem to be several options here:

Per @esander's suggestion switch to closest color (@background-color-success-subtle;) possibly with a rename to describe it's use semantically https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1216771
Replace color with a different color e.g.@background-color-backdrop-light

Screenshot 2025-12-09 at 5.01.49 PM.png (881×936 px, 102 KB)

Create a new token
...

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Other Assignee: Volker_E

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	mediawiki.content.json: Use neutral tokens for JSON tables	mediawiki/core	master	+7 -21

Customize query in gerrit

Event Timeline

Jdlrobson-WMF created this task.Dec 10 2025, 1:03 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2025, 1:03 AM

Change #1216771 had a related patch set uploaded (by Jdlrobson; author: Esanders):

[mediawiki/core@master] JsonContent: Use background-color-success-subtle for JSON tables

https://gerrit.wikimedia.org/r/1216771

gerritbot added a project: Patch-For-Review.Dec 10 2025, 1:03 AM

We can't see two of those files. See https://www.mediawiki.org/w/index.php?title=Phabricator/Help#File_visibility

Pppery unsubscribed.Dec 10 2025, 1:06 AM

What is the reason for the coloring of the cells? Before we go into token application action it would be helpful to understand the why better:

For signaling a certain value quality? No.
For signaling a value over a value container. Yes.

For latter and in order to not confuse with validation, I'd recommend

treatment.

In case we're going to have table highlights design tokens, I'd opt for a light violet instead of a green hue.

That seems like a reasonable follow-up. I just want to merge the least controversial change that would remove the dark-mode hacks.

Volker_E closed this task as Resolved.Tue, Dec 16, 7:00 PM

Volker_E assigned this task to Esanders.

Volker_E triaged this task as Medium priority.

Volker_E removed a project: Patch-For-Review.

Volker_E updated Other Assignee, added: Volker_E.

Change #1216771 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.content.json: Use neutral tokens for JSON tables

https://gerrit.wikimedia.org/r/1216771

Jdlrobson-WMF added projects: Verified, Reader Experience Team (REx Sprint 12 [Q2 Dec 16 - Jan 26]), Unplanned-Sprint-Work.Thu, Jan 8, 10:50 PM

Jdlrobson-WMF moved this task from Ready to Sign-off on the Reader Experience Team (REx Sprint 12 [Q2 Dec 16 - Jan 26]) board.Wed, Jan 14, 5:48 PM

	F70971293: Screenshot 2025-12-09 at 5.01.49 PM.png
	Dec 10 2025, 1:03 AM

	F70971195: Screenshot 2025-12-09 at 4.57.01 PM.png
	Dec 10 2025, 1:03 AM

	F70971187: Screenshot 2025-12-09 at 4.56.45 PM.png
	Dec 10 2025, 1:03 AM

	F70989616: image.png
	Dec 10 2025, 7:41 PM

JSON uses non-standard Codex design tokensClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

JSON uses non-standard Codex design tokens
Closed, ResolvedPublicBUG REPORT
Actions