Page MenuHomePhabricator
Create Task
Maniphest T412193

Deprecated: Using null as an array offset is deprecated, use an empty string instead in WikimediaEvents/includes/AccountCreation/AccountCreationLogger.php on line 181
Closed, ResolvedPublic
Actions

Description

After upgrading my dev wiki to PHP 8.5:

image.png (80×1 px, 66 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Avoid casting -INF to intmediawiki/extensions/WikimediaEventsmaster+3 -2
Avoid using null as array keymediawiki/extensions/WikimediaEventsmaster+1 -1
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Dec 10 2025, 10:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2025, 10:59 AM
gerritbot added a comment.Dec 10 2025, 11:00 AM

Change #1217139 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikimediaEvents@master] Avoid using null as array key

https://gerrit.wikimedia.org/r/1217139

gerritbot added a project: Patch-For-Review.Dec 10 2025, 11:00 AM
Lucas_Werkmeister_WMDE added a comment.Dec 10 2025, 11:17 AM

And another when looking at an API result (api.php?action=query&prop=revisions&revids=7984):

Warning: The float -INF is not representable as an int, cast occurred in /srv/http/wiki1/extensions/WikimediaEvents/includes/WikimediaEventsHooks.php on line 495
Warning: The float -INF is not representable as an int, cast occurred in /srv/http/wiki1/extensions/WikimediaEvents/includes/WikimediaEventsHooks.php on line 495

gerritbot added a comment.Dec 10 2025, 11:21 AM

Change #1217143 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikimediaEvents@master] Avoid casting -INF to int

https://gerrit.wikimedia.org/r/1217143

gerritbot added a comment.Dec 11 2025, 9:47 AM

Change #1217139 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Avoid using null as array key

https://gerrit.wikimedia.org/r/1217139

gerritbot added a comment.Dec 11 2025, 9:47 AM

Change #1217143 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Avoid casting -INF to int

https://gerrit.wikimedia.org/r/1217143

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 11 2025, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 11 2025, 10:31 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 11 2025, 11:20 AM
Lucas_Werkmeister_WMDE claimed this task.

Let’s optimistically close this as resolved, but reopen it if there are more PHP 8.5 issues in WikimediaEvents (not worth opening a bunch of separate tickets for IMHO).

Also, given WikimediaEvents’ “target audience” (Wikimedia wikis), I assume there’s no need to backport these fixes to release branches.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits