Page MenuHomePhabricator

Deprecated: The predefined locally scoped $http_response_header variable is deprecated, call http_get_last_response_headers() instead in …/vendor/justinrainbow/json-schema/src/JsonSchema/Uri/Retrievers/FileGetContents.php on line 55
Closed, ResolvedPublic

Description

Our version of justinrainbow/json-schema (5.3.0) is using an access pattern that is deprecated in PHP 8.5. Two fixes appear to be available from versions 6.5.0 and 6.5.1 respectively; alternatively, there’s an open task for migrating away from this library altogether (T293710).

Event Timeline

Change #1218854 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@master] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1218854

Change #1218855 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1218855

We can also just grab 5.3.1...

Now that it exists (which it didn’t when I created the task), sure! ^^

Change #1218854 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1218854

Change #1218855 merged by jenkins-bot:

[mediawiki/core@master] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1218855

I guess the task stays open for backporting to release branches? (I’m not sure how that works in this case – are vendor changes backported to REL branches?)

Change #1219223 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_45] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219223

Change #1219224 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@REL1_44] composer.json: Relax justinrainbow/json-schema constraint and allow ^6.4.2

https://gerrit.wikimedia.org/r/1219224

Change #1219225 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@REL1_43] composer.json: Relax justinrainbow/json-schema constraint and allow ^6.4.2

https://gerrit.wikimedia.org/r/1219225

Change #1219225 abandoned by Reedy:

[mediawiki/services/parsoid@REL1_43] composer.json: Relax justinrainbow/json-schema constraint and allow ^6.4.2

https://gerrit.wikimedia.org/r/1219225

Change #1219226 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_43] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219226

Change #1219223 merged by Reedy:

[mediawiki/vendor@REL1_45] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219223

Change #1219226 merged by Reedy:

[mediawiki/vendor@REL1_43] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219226

Change #1219227 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_45] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219227

Change #1219228 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_44] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219228

Change #1219229 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_43] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219229

Change #1219227 merged by jenkins-bot:

[mediawiki/core@REL1_45] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219227

Change #1219229 merged by jenkins-bot:

[mediawiki/core@REL1_43] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219229

Change #1219224 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_44] composer.json: Relax justinrainbow/json-schema constraint and allow ^6.4.2

https://gerrit.wikimedia.org/r/1219224

Change #1221215 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@REL1_44] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1221215

Change #1221215 merged by Reedy:

[mediawiki/vendor@REL1_44] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1221215

Change #1219228 merged by jenkins-bot:

[mediawiki/core@REL1_44] Upgrading justinrainbow/json-schema (5.3.0 => 5.3.1)

https://gerrit.wikimedia.org/r/1219228

Reedy claimed this task.
Reedy changed the status of subtask T413545: Tag new parsoid releases for existing REL1_XX branches from Open to In Progress.