Page MenuHomePhabricator
Create Task
Maniphest T412223

Toolbar can become misaligned when edit check is open
Closed, ResolvedPublic
Actions

Description

  • Open VE desktop with edit check
  • With the page scrolled to the top, resize the window to a narrow size, then back to a wide size
  • Scroll down

Observe that the toolbar is incorrectly positioned:

image.png (994×121 px, 43 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (17a600756)Esandersmediawiki/extensions/VisualEditormaster+16 -10
Use position:sticky for floating toolbarEsandersVisualEditor/VisualEditormaster+24 -39
Customize query in gerrit

Event Timeline

Esanders created this task.Dec 10 2025, 2:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2025, 2:46 PM
Esanders added a comment.Dec 10 2025, 3:09 PM

This would be nicely solved by switching to using position: sticky. We've had a patch open since 2017 although at that time support was considered a bit "experimental". It's now been around long enough and used by enough products that we should consider it stable.

gerritbot added a comment.Dec 10 2025, 3:09 PM

Change #384579 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Use position:sticky for floating toolbar when supported

https://gerrit.wikimedia.org/r/384579

gerritbot added a project: Patch-For-Review.Dec 10 2025, 3:09 PM
PatchDemoBot added a comment.Dec 10 2025, 3:13 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://3e29c2e65d.catalyst.wmcloud.org/wiki/Douglas Adams

Esanders claimed this task.Dec 10 2025, 3:16 PM
Esanders added a project: Editing-team (Kanban Board).
DLynch subscribed.Dec 10 2025, 4:29 PM

I can't reproduce the original issue, so it might be something even more specific than you have listed.

Using sticky seems reasonable, though.

Esanders added a comment.Dec 10 2025, 5:28 PM
In T412223#11448018, @DLynch wrote:

I can't reproduce the original issue, so it might be something even more specific than you have listed.

Using sticky seems reasonable, though.

You may need to float/unfloat the toolbar a few times as well, before resizing.

Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Jan 19 2026, 12:07 PM
Esanders added a project: OKR-Work.Jan 22 2026, 1:05 PM
ldelench_wmf edited projects, added: Editing-team; removed: Editing-team (Kanban Board).Feb 2 2026, 9:31 PM
ldelench_wmf moved this task from Untriaged to Editing-Q4-2025-2026 on the Editing-team board.
PatchDemoBot added a comment.Feb 12 2026, 4:23 PM

Test wiki created on Patch demo by DLynch (WMF) using patch(es) linked to this task:
https://4b1f432149.catalyst.wmcloud.org/w/

gerritbot added a comment.Feb 13 2026, 5:29 PM

Change #384579 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Use position:sticky for floating toolbar

https://gerrit.wikimedia.org/r/384579

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2026, 5:30 PM
gerritbot added a comment.Feb 13 2026, 6:13 PM

Change #1217218 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (17a600756)

https://gerrit.wikimedia.org/r/1217218

gerritbot added a project: Patch-For-Review.Feb 13 2026, 6:13 PM
gerritbot added a comment.Feb 13 2026, 7:50 PM

Change #1217218 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (17a600756)

https://gerrit.wikimedia.org/r/1217218

DLynch edited projects, added: Editing QA, Editing-team (Editing-2Feb-17Feb-2026); removed: Editing-team.Feb 13 2026, 8:06 PM
DLynch moved this task from Decisions to be made to QA on the Editing-team (Editing-2Feb-17Feb-2026) board.
Maintenance_bot removed a project: Patch-For-Review.Feb 13 2026, 8:31 PM
ppelberg edited projects, added: Editing-team (Editing-18Feb-27Feb-2026); removed: Editing-team (Editing-2Feb-17Feb-2026).Feb 18 2026, 9:06 PM
ppelberg moved this task from Decisions to be made to QA on the Editing-team (Editing-18Feb-27Feb-2026) board.
ldelench_wmf edited projects, added: Editing-team (Editing-2Mar-17Mar-2026); removed: Editing-team (Editing-18Feb-27Feb-2026).Mar 5 2026, 7:58 PM
Esanders moved this task from Decisions to be made to QA on the Editing-team (Editing-2Mar-17Mar-2026) board.Mar 5 2026, 7:59 PM
ldelench_wmf closed this task as Resolved.Mar 5 2026, 8:22 PM
ldelench_wmf subscribed.

Looks good to me, feel free to reopen if you notice anything awry

PatchDemoBot added a comment.Mar 12 2026, 9:30 AM

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://3e29c2e65d.catalyst.wmcloud.org/w/

PatchDemoBot added a comment.Apr 5 2026, 7:02 PM

Test wiki on Patch demo by DLynch (WMF) using patch(es) linked to this task was deleted:

https://4b1f432149.catalyst.wmcloud.org/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits