Page MenuHomePhabricator

Deprecate support for namespaces key in SkinTemplateNavigation::Universal
Closed, ResolvedPublic

Description

Background

There are various skins using SkinTemplateNavigation::Universal and adding items to the namespaces menu. The Skin code in MediaWiki core has additional code that is triggered by this to move the item to the associated-pages menu. This requires additional code to support and is causing confusion when working with the code. On top of this new code is being written that is making it harder to remove this compability code.

We need fixes in various Wikimedia production extension to begin the deprecation process so we can remove the code supporting this.

Plan

  • Fix T409774: Deprecate legacy "personal" and "namespaces" menu from SkinTemplate (Cologneblue and modern are not blockers)
  • Update extensions in production using the hook to modify namespaces (VisualEditor and GrowthExperiments are the only two remaining extensions)
  • Core should send deprecation warnings when namespace key is modified
  • be remove in future task (will create follow up)
$wgHooks['SkinTemplateNavigation::Universal'][] = function ( $t, &$s ) {
	$s['namespaces']['bookmark'] = [
		'icon' => 'bookmark',
		'text' => 'bookmark',
		'href' => '/wiki/Foo'
	];
};

Event Timeline

Change #1217247 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Remove backwards compatibility of SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/1217247

Change #1217252 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Deprecate modification of the namespaces hook in SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/1217252

Change #1223732 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/GrowthExperiments@master] `namespaces` menu is deprecated, use associated-pages instead

https://gerrit.wikimedia.org/r/1223732

Change #1224189 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ProofreadPage@master] Do not use deprecated menu

https://gerrit.wikimedia.org/r/1224189

Change #1224189 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Do not use deprecated menu

https://gerrit.wikimedia.org/r/1224189

Change #1224723 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Translate@master] Use associated-pages menu rather than soon to be deprecated namespaces

https://gerrit.wikimedia.org/r/1224723

Change #1224724 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/TimedMediaHandler@master] Use associated-pages rather than deprecated namespaces menu

https://gerrit.wikimedia.org/r/1224724

Change #1224728 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/CommunityRequests@master] Prepare for removal of namespaces menu

https://gerrit.wikimedia.org/r/1224728

Change #1224736 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] Use getAssociatedNavigationLinks for adding tabs to special pages

https://gerrit.wikimedia.org/r/1224736

Change #1224728 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Prepare for removal of namespaces menu

https://gerrit.wikimedia.org/r/1224728

Change #1224724 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Use associated-pages rather than deprecated namespaces menu

https://gerrit.wikimedia.org/r/1224724

Change #1224723 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use associated-pages menu rather than soon to be deprecated namespaces

https://gerrit.wikimedia.org/r/1224723

Change #1224770 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Fix logic in injectLegacyMenusIntoPersonalTools

https://gerrit.wikimedia.org/r/1224770

Jdlrobson-WMF added subscribers: Urbanecm_WMF, Esanders.

Hi @Esanders @Urbanecm_WMF could you help me get the associated fixes into VisualEditor and GrowthExperiments so we can move ahead with this deprecation?

Change #1224770 merged by jenkins-bot:

[mediawiki/core@master] Fix logic in injectLegacyMenusIntoPersonalTools

https://gerrit.wikimedia.org/r/1224770

Change #1226946 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ProofreadPage@master] Do not use deprecated menu (attempt 2)

https://gerrit.wikimedia.org/r/1226946

Jdlrobson-WMF renamed this task from Drop support for namespaces key in SkinTemplateNavigation::Universal to Deprecate support for namespaces key in SkinTemplateNavigation::Universal.Jan 14 2026, 10:43 PM
Jdlrobson-WMF updated the task description. (Show Details)
Jdlrobson-WMF updated the task description. (Show Details)

Change #1224736 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use getAssociatedNavigationLinks for adding tabs to special pages

https://gerrit.wikimedia.org/r/1224736

Change #1223732 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] `namespaces` menu is deprecated, use associated-pages instead

https://gerrit.wikimedia.org/r/1223732

Change #1226946 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Do not use deprecated menu (attempt 2)

https://gerrit.wikimedia.org/r/1226946

Change #1217252 merged by jenkins-bot:

[mediawiki/core@master] Deprecate modification of the namespaces hook in SkinTemplateNavigation::Universal

https://gerrit.wikimedia.org/r/1217252

Jdlrobson-WMF claimed this task.

I've created T416651: Remove backwards compatibility for SkinTemplateNavigation::Universal modification of namespaces menu.
I'll help with addressing deprecations in third parties over the course of the next 6 months.

Change #1217247 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] [1.47 DO NOT MERGE] Remove backwards compatibility of SkinTemplateNavigation hook

https://gerrit.wikimedia.org/r/1217247

Change #1249295 had a related patch set uploaded (by Abijeet Patro; author: Jdlrobson):

[mediawiki/extensions/Translate@mleb-2026.01] Use associated-pages menu rather than soon to be deprecated namespaces

https://gerrit.wikimedia.org/r/1249295

Change #1249295 merged by jenkins-bot:

[mediawiki/extensions/Translate@mleb-2026.01] Use associated-pages menu rather than soon to be deprecated namespaces

https://gerrit.wikimedia.org/r/1249295