Steps to replicate the issue (include links if applicable):
- SSH to cumin1003 and open a Python shell as root
- Create a new spicerack.service_catalog() and attempt to print its entries:
>>> from spicerack import Spicerack >>> spicerack = Spicerack() >>> catalog = spicerack.service_catalog() >>> for service in catalog: print(service)
What happens?:
Error message:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3/dist-packages/spicerack/service.py", line 575, in <genexpr>
return (self.get(name) for name in self._catalog)
^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/spicerack/service.py", line 630, in get
return Service(**params)
^^^^^^^^^^^^^^^^^
TypeError: Service.__init__() got an unexpected keyword argument 'exclude_from_switchover'`What should have happened instead?:
Printing all the entries of service catalog.
Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
Python3 and current version deployed on cumin1003 (I didn't install anything specific for this test).
However this happened after https://gerrit.wikimedia.org/r/c/operations/puppet/+/1217189 got merged, where the new exclude_from_switchover field got created.