Page MenuHomePhabricator
Create Task
Maniphest T412518

Release a new version of TestingAccessWrapper
Closed, ResolvedPublicBUG REPORT
Actions

Description

There are changes that are needed to use TestingAccessWrapper with PHP 8.5

https://github.com/wikimedia/testing-access-wrapper/compare/3.0.0...master

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drop support for wikimedia/testing-access-wrapper 3.0.0mediawiki/coremaster+1 -1
build: Drop back-compatibility for testing-access-wrapper and pin; 4+ required for PHP 8.5mediawiki/coremaster+7 -6
Upgrade wikimedia/testing-access-wrapper to 4.0performance/excimer-ui-clientmaster+1 -1
Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/libs/Messagemaster+1 -1
Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/libs/ParamValidatormaster+1 -1
Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/extensions/PageNoticemaster+1 -1
Allow wikimedia/testing-access-wrapper ^4.0.0mediawiki/extensions/DonationInterfacemaster+1 -1
Bump wikimedia/parsoid to 0.23.0-a10mediawiki/vendormaster+342 -158
Allow wikimedia/testing-access-wrapper ^4.0.0mediawiki/coreREL1_44+1 -1
Allow wikimedia/testing-access-wrapper ^4.0.0mediawiki/coreREL1_43+1 -1
Allow wikimedia/testing-access-wrapper ^4.0.0mediawiki/coreREL1_45+1 -1
Allow wikimedia/testing-access-wrapper ^4.0.0mediawiki/coremaster+1 -1
Upgrading wikimedia/testing-access-wrapper (3.0.0 => 4.0.0)mediawiki/vendormaster+51 -87
composer.json: Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/services/parsoidREL1_45+1 -1
composer.json: Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/services/parsoidREL1_43+1 -1
composer.json: Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/services/parsoidREL1_44+1 -1
composer.json: Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/services/parsoidmaster+1 -1
composer.json: Allow wikimedia/testing-access-wrapper 4.0.0css-sanitizermaster+1 -1
composer.json: Allow wikimedia/testing-access-wrapper 4.0.0RunningStatmaster+1 -1
composer.json: Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/libs/Minifymaster+1 -1
composer.json: Allow wikimedia/testing-access-wrapper 4.0.0mediawiki/libs/Zestmaster+1 -1
Show related patches Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
composer: Various updatesrepos/data-engineering/metrics-platform!116reedybumpandupdatemain
Customize query in GitLab

Related Objects
Search...

Event Timeline

Ammarpad created this task.Dec 12 2025, 12:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 12 2025, 12:50 PM
Ammarpad mentioned this in T412850: TestingAccessWrapper: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect.Dec 16 2025, 6:27 PM
Reedy added a project: Release.Dec 16 2025, 6:33 PM
Reedy updated the task description. (Show Details)
Reedy triaged this task as High priority.Dec 29 2025, 9:07 PM
Reedy added a parent task: T412850: TestingAccessWrapper: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect.
Reedy added a project: PHP 8.5 support.
Reedy subscribed.

https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-vendor-mysql-php85/3/consoleFull

317/661 errors just from the error in T412850: TestingAccessWrapper: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect is a lot...

gerritbot added a comment.Dec 29 2025, 9:24 PM

Change #1221661 had a related patch set uploaded (by Reedy; author: Reedy):

[css-sanitizer@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221661

gerritbot added a project: Patch-For-Review.Dec 29 2025, 9:24 PM

Change #1221662 had a related patch set uploaded (by Reedy; author: Reedy):

[RunningStat@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221662

gerritbot added a comment.Dec 29 2025, 9:26 PM

Change #1221663 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/Minify@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221663

gerritbot added a comment.Dec 29 2025, 9:26 PM

Change #1221664 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/libs/Zest@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221664

gerritbot added a comment.Dec 29 2025, 9:27 PM

Change #1221665 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221665

CodeReviewBot added a comment.Dec 29 2025, 9:37 PM

reedy updated https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/116

composer:

Reedy added a comment.Dec 29 2025, 9:47 PM
In T412518#11486779, @Reedy wrote:

https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-vendor-mysql-php85/3/consoleFull

317/661 errors just from the error in T412850: TestingAccessWrapper: Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect is a lot...

Make that 598/661 (searching for setAccessible() is deprecated since 8.5, as it has no effect)

Reedy moved this task from Backlog to Other on the PHP 8.5 support board.Dec 29 2025, 9:55 PM
gerritbot added a comment.Dec 29 2025, 11:59 PM

Change #1221664 merged by jenkins-bot:

[mediawiki/libs/Zest@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221664

gerritbot added a comment.Dec 29 2025, 11:59 PM

Change #1221663 merged by jenkins-bot:

[mediawiki/libs/Minify@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221663

gerritbot added a comment.Dec 29 2025, 11:59 PM

Change #1221662 merged by jenkins-bot:

[RunningStat@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221662

gerritbot added a comment.Dec 29 2025, 11:59 PM

Change #1221661 merged by jenkins-bot:

[css-sanitizer@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221661

gerritbot added a comment.Dec 30 2025, 12:13 AM

Change #1221665 merged by jenkins-bot:

[mediawiki/services/parsoid@master] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221665

gerritbot added a comment.Dec 30 2025, 12:13 AM

Change #1221683 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@REL1_45] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221683

gerritbot added a comment.Dec 30 2025, 12:14 AM

Change #1221684 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@REL1_44] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221684

gerritbot added a comment.Dec 30 2025, 12:14 AM

Change #1221685 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/services/parsoid@REL1_43] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221685

gerritbot added a comment.Dec 30 2025, 12:29 AM

Change #1221684 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_44] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221684

gerritbot added a comment.Dec 30 2025, 12:31 AM

Change #1221685 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_43] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221685

gerritbot added a comment.Dec 30 2025, 12:33 AM

Change #1221683 merged by jenkins-bot:

[mediawiki/services/parsoid@REL1_45] composer.json: Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1221683

Reedy mentioned this in rCSSS4fb87f69544d: composer.json: Allow wikimedia/testing-access-wrapper 4.0.0.Dec 30 2025, 2:17 AM
gerritbot added a comment.Dec 30 2025, 2:58 PM

Change #1221974 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/vendor@master] Upgrading wikimedia/testing-access-wrapper (3.0.0 => 4.0.0)

https://gerrit.wikimedia.org/r/1221974

gerritbot added a comment.Dec 30 2025, 3:00 PM

Change #1221975 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Allowwikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1221975

gerritbot added a comment.Dec 30 2025, 3:25 PM

Change #1221978 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] Upgrading wikimedia/testing-access-wrapper (3.0.0 => 4.0.0)

https://gerrit.wikimedia.org/r/1221978

Ammarpad mentioned this in T413581: Error: Call to a member function deregisterSession() on null.Jan 1 2026, 3:30 PM
Reedy added a parent task: T413581: Error: Call to a member function deregisterSession() on null.Jan 1 2026, 4:49 PM
gerritbot added a comment.Jan 2 2026, 8:19 PM

Change #1221974 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrading wikimedia/testing-access-wrapper (3.0.0 => 4.0.0)

https://gerrit.wikimedia.org/r/1221974

gerritbot added a comment.Jan 2 2026, 8:20 PM

Change #1221975 merged by jenkins-bot:

[mediawiki/core@master] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1221975

Reedy lowered the priority of this task from High to Medium.Jan 2 2026, 11:57 PM
gerritbot added a comment.Jan 3 2026, 4:36 PM

Change #1222726 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_43] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1222726

gerritbot added a comment.Jan 3 2026, 4:36 PM

Change #1222727 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_45] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1222727

gerritbot added a comment.Jan 3 2026, 4:36 PM

Change #1222728 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_44] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1222728

gerritbot added a comment.Jan 3 2026, 5:06 PM

Change #1222727 merged by jenkins-bot:

[mediawiki/core@REL1_45] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1222727

gerritbot added a comment.Jan 3 2026, 5:06 PM

Change #1222726 merged by jenkins-bot:

[mediawiki/core@REL1_43] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1222726

gerritbot added a comment.Jan 3 2026, 5:10 PM

Change #1222728 merged by jenkins-bot:

[mediawiki/core@REL1_44] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1222728

A_smart_kitten mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Jan 5 2026, 9:44 AM
gerritbot added a comment.Jan 5 2026, 5:44 PM

Change #1223225 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a10

https://gerrit.wikimedia.org/r/1223225

gerritbot added a comment.Jan 5 2026, 6:48 PM

Change #1223225 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.23.0-a10

https://gerrit.wikimedia.org/r/1223225

CodeReviewBot added a comment.Jan 9 2026, 1:39 PM

sfaci merged https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/116

composer: Various updates

gerritbot added a comment.Jan 12 2026, 11:17 AM

Change #1225520 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/PageNotice@master] Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1225520

gerritbot added a comment.Jan 12 2026, 11:18 AM

Change #1225521 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/DonationInterface@master] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1225521

gerritbot added a comment.Jan 15 2026, 4:36 PM

Change #1225521 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Allow wikimedia/testing-access-wrapper ^4.0.0

https://gerrit.wikimedia.org/r/1225521

gerritbot added a comment.Jan 15 2026, 4:42 PM

Change #1225520 merged by jenkins-bot:

[mediawiki/extensions/PageNotice@master] Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1225520

gerritbot added a comment.Jan 17 2026, 11:31 PM

Change #1228248 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/libs/ParamValidator@master] Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1228248

gerritbot added a comment.Jan 17 2026, 11:32 PM

Change #1228249 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/libs/Message@master] Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1228249

gerritbot added a comment.Jan 17 2026, 11:34 PM

Change #1228250 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[performance/excimer-ui-client@master] Upgrade wikimedia/testing-access-wrapper to 4.0

https://gerrit.wikimedia.org/r/1228250

gerritbot added a comment.Jan 18 2026, 3:14 PM

Change #1228248 merged by jenkins-bot:

[mediawiki/libs/ParamValidator@master] Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1228248

gerritbot added a comment.Jan 18 2026, 3:14 PM

Change #1228249 merged by jenkins-bot:

[mediawiki/libs/Message@master] Allow wikimedia/testing-access-wrapper 4.0.0

https://gerrit.wikimedia.org/r/1228249

Jdforrester-WMF subscribed.Jan 21 2026, 1:07 AM

Per https://libup.wmcloud.org/library/composer/wikimedia/testing-access-wrapper?branch=main the last remaining repo to allow 4.0.0 in is https://gerrit.wikimedia.org/r/q/project:performance/excimer-ui-client

(We should also drop 3.0, and especially 2.0, claimed support, if we're going to claim PHP 8.5 support in each of these repos.)

gerritbot added a comment.Jan 21 2026, 9:21 PM

Change #1228250 merged by jenkins-bot:

[performance/excimer-ui-client@master] Upgrade wikimedia/testing-access-wrapper to 4.0

https://gerrit.wikimedia.org/r/1228250

Umherirrender closed this task as Resolved.Jan 21 2026, 9:32 PM
gerritbot added a comment.Jan 21 2026, 9:36 PM

Change #1229709 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] build: Drop back-compatibility for testing-access-wrapper and pin; 4+ required for PHP 8.5

https://gerrit.wikimedia.org/r/1229709

gerritbot added a comment.Jan 27 2026, 2:02 AM

Change #1229709 merged by jenkins-bot:

[mediawiki/core@master] build: Drop back-compatibility for testing-access-wrapper and pin; 4+ required for PHP 8.5

https://gerrit.wikimedia.org/r/1229709

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.14; 2026-02-03).Jan 27 2026, 3:00 AM
gerritbot added a comment.Jan 27 2026, 3:01 PM

Change #1221978 abandoned by Jforrester:

[mediawiki/core@master] Drop support for wikimedia/testing-access-wrapper 3.0.0

https://gerrit.wikimedia.org/r/1221978

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits